Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdlog 1.9.1 #82118

Closed
wants to merge 1 commit into from
Closed

spdlog 1.9.1 #82118

wants to merge 1 commit into from

Conversation

bayandin
Copy link
Member

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Jul 29, 2021
@bayandin
Copy link
Member Author

/tmp/spdlog-20210729-43361-kh47zy/spdlog-1.9.1/include/spdlog/common.h:141:72: error: no template named 'format_string' in namespace 'fmt'; did you mean 'format_to_n'?
    : std::integral_constant<bool, std::is_convertible<const T &, fmt::format_string<>>::value || is_convertible_to_wformat_string<T>::value>
                                                                  ~~~~~^~~~~~~~~~~~~
                                                                       format_to_n
/opt/homebrew/include/fmt/core.h:2035:13: note: 'format_to_n' declared here
inline auto format_to_n(OutputIt out, size_t n, const S& format_str,
            ^
In file included from /tmp/spdlog-20210729-43361-kh47zy/spdlog-1.9.1/src/spdlog.cpp:8:
In file included from /tmp/spdlog-20210729-43361-kh47zy/spdlog-1.9.1/include/spdlog/spdlog-inl.h:7:
In file included from /tmp/spdlog-20210729-43361-kh47zy/spdlog-1.9.1/include/spdlog/spdlog.h:12:
/tmp/spdlog-20210729-43361-kh47zy/spdlog-1.9.1/include/spdlog/common.h:141:67: error: template argument for template type parameter must be a type
    : std::integral_constant<bool, std::is_convertible<const T &, fmt::format_string<>>::value || is_convertible_to_wformat_string<T>::value>
                                                                  ^~~~~~~~~~~~~~~~~~~~

@bayandin bayandin added the build failure CI fails while building the software label Jul 29, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Aug 1, 2021
@alebcay
Copy link
Member

alebcay commented Aug 1, 2021

This needs fmt >= 8.0.0 to build - maybe we can add this commit to #79836? spdlog is being bumped in that PR but the old version of spdlog doesn't support fmt >= 8.0.0 so hopefully this will fix some things in that PR too.

@github-actions github-actions bot removed the stale No recent activity label Aug 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Aug 3, 2021
@bayandin
Copy link
Member Author

bayandin commented Aug 3, 2021

This needs fmt >= 8.0.0 to build - maybe we can add this commit to #79836? spdlog is being bumped in that PR but the old version of spdlog doesn't support fmt >= 8.0.0 so hopefully this will fix some things in that PR too.

Added to #79836, thanks!

@bayandin bayandin closed this Aug 3, 2021
@bayandin bayandin deleted the bump-spdlog-1.9.1 branch August 3, 2021 10:53
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build failure CI fails while building the software bump-formula-pr PR was created using `brew bump-formula-pr` outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants