Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnscrypt-proxy 1.9.1 #8396

Closed
wants to merge 1 commit into from
Closed

dnscrypt-proxy 1.9.1 #8396

wants to merge 1 commit into from

Conversation

ilovezfs
Copy link
Contributor

@ilovezfs ilovezfs commented Jan 2, 2017

Created with brew bump-formula-pr.

@justinmayer
Copy link
Contributor

@ilovezfs: Have you considered moving DNSCrypt settings from plist CLI flags to the configuration file introduced in v1.8?

As in stands now, all settings changes in the plist (for example, resolver) are overwritten on each brew upgrade, which seems rather suboptimal. Moving the current defaults to an example file at /use/local/etc/dnscrypt-proxy-example.conf and switching the plist to call /use/local/etc/dnscrypt-proxy.conf seems like a more resilient approach. Doing so would also be more consistent with the behavior of other Homebrew formulae.

What do you think?

@ilovezfs
Copy link
Contributor Author

ilovezfs commented Jan 2, 2017

@justinmayer sounds reasonable. Do you mind opening a PR? I can close this one if you'd like.

@nijikon
Copy link
Contributor

nijikon commented Jan 3, 2017 •
edited
Loading

I'm merging this. The thing that you are discussing can be done in a separate PR.

@nijikon nijikon closed this in c40ce83 Jan 3, 2017
@justinmayer justinmayer mentioned this pull request Jan 10, 2017
Closed
@justinmayer
Copy link
Contributor

justinmayer commented Jan 11, 2017 •
edited
Loading

I attempted to switch DNSCrypt's formula to use a configuration file, but I'm a bit stumped as to how to accomplish that given brew's auto-linking behavior. I created an issue in case anyone has any suggestions: #8711

justinmayer added a commit to justinmayer/homebrew-core that referenced this pull request Jan 24, 2017
@justinmayer
dnscrypt-proxy 1.9.4
fd7a986 
This updates dnscrypt-proxy to version 1.9.4. It also moves settings
from the plist to a configuration file, as explained below.

Configuring DNSCrypt settings via arguments in the plist meant that
changes were overwritten on each `brew upgrade`. Since DNSCrypt recently
added support for configuration files, this formula now uses the
configuration file in order to allow for persistent DNSCrypt settings.

Refs Homebrew#8396
ilovezfs pushed a commit that referenced this pull request Jan 24, 2017
@justinmayer @ilovezfs
dnscrypt-proxy 1.9.4
dde7062 
This updates dnscrypt-proxy to version 1.9.4. It also moves settings
from the plist to a configuration file, as explained below.

Configuring DNSCrypt settings via arguments in the plist meant that
changes were overwritten on each `brew upgrade`. Since DNSCrypt recently
added support for configuration files, this formula now uses the
configuration file in order to allow for persistent DNSCrypt settings.

Refs #8396

Closes #8818.

Signed-off-by: ilovezfs <ilovezfs@icloud.com>
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilovezfs @justinmayer @nijikon