Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapel 1.25.0 #85813

Closed
wants to merge 1 commit into from
Closed

Chapel 1.25.0 #85813

wants to merge 1 commit into from

Conversation

Maxrimus
Copy link
Contributor

Signed-off-by: Joe Tursi joe.p.tursi@gmail.com

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This updates the formula to reflect today’s Chapel 1.25.0 release, whose CHANGES log is here https://github.com/chapel-lang/chapel/blob/main/CHANGES.md.

Signed-off-by: Joe Tursi <joe.p.tursi@gmail.com>
@BrewTestBot BrewTestBot added no ARM bottle Formula has no ARM bottle python Python use is a significant feature of the PR or issue labels Sep 23, 2021
@SMillerDev SMillerDev added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Sep 24, 2021
depends_on "python@3.9"

def install
libexec.install Dir["*"]
# Chapel uses this ENV to work out where to install.
ENV["CHPL_HOME"] = libexec
# This is for mason
ENV["CHPL_REGEXP"] = "re2"
ENV["CHPL_RE2"] = "bundled"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't it use the system/homebrew one?

Copy link

@bradcray bradcray Sep 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SMillerDev: No, as we discussed here, we have patches to re2 to extend its capabilities for Chapel that have not been accepted upstream.

[edit: apologies @SMillerDev — I was recognizing your handle, but misremembering it as being from the discussion about third-party packages in the Chapel 1.24.0 release when in fact it was from the help you gave me on trying to figure out how to get Chapel download counts. I wordsmithed my previous comment to correct that misunderstanding]

Comment on lines +33 to +34
ENV.delete("CC")
ENV.delete("CXX")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why delete these?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We found an 11th hour bug in our Makefile system that caused system clang rather than homebrew's llvm@11 clang to be used as the C compiler for certain build steps, so making these settings worked around the bug for now; we expect to address this in our next Chapel release to avoid the workaround. chapel-lang/chapel#18450 tracks this issue.

rm_rf("third-party/gasnet/gasnet-src")
rm_rf("third-party/libfabric/libfabric-src")
rm_rf("third-party/fltk/fltk-1.3.5-source.tar.gz")
rm_rf("third-party/libunwind/libunwind-1.1.tar.gz")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't it use the homebrew version?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need to use any of these so we are deleting them to save disk space. The homebrew version of Chapel is designed for shared-memory execution only, so does not require gasnet or libfabric. Macs have their own system unwind, so libunwind isn't required. And we don't use fltk in the homebrew release.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@bradcray
Copy link

Thanks @carlocab!

@github-actions github-actions bot added the outdated PR was locked due to age label Oct 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. no ARM bottle Formula has no ARM bottle outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants