wine 2.0 #9238
wine 2.0 #9238
Conversation
| # https://bugs.winehq.org/show_bug.cgi?id=34166 | ||
| patch do | ||
| url "https://bugs.winehq.org/attachment.cgi?id=52485" | ||
| sha256 "59f1831a1b49c1b7a4c6e6af7e3f89f0bc60bec0bead645a615b251d37d232ac" |
There was a problem hiding this comment.
Should this patch actually be removed, or just replaced with https://bugs.winehq.org/attachment.cgi?id=55968 ?
|
The |
| patch do | ||
| url "https://bugs.winehq.org/attachment.cgi?id=55968" | ||
| sha256 "1b5086798ce6dc959b3cbb8f343ee236ae06c7910e4bbae7d9fde3f162f03a79" | ||
| end |
There was a problem hiding this comment.
If these patches aren't getting merged upstream we should strongly consider removing them. Any information on why upstream won't merge them?
|
@MikeMcQuaid This comment explains it in some detail. Basically, they consider it a bug in Apple's OpenGL implementation, so they view hacking around it in Wine itself as some sort of moral compromise they're not willing to make, even though it does resolve the issue. |
|
@apetresc We need to get some resolution here, we can't just carry these unmerged patches forever. I've commented in https://bugs.winehq.org/show_bug.cgi?id=14939 and https://bugs.winehq.org/show_bug.cgi?id=34166 and let's hold off on this merge until there's more news. |
|
Hi, any updates on this? Wine 2.0 patch is kinda important... |
|
@xrisk: It looks like Mike is still going back-and-forth with the Wine developers in those two tickets, with responses as recently as this morning. So, it's still being figured out. As expected, they're resisting merging the patches upstream (for some seemingly good reasons, too). |
|
@uyjulian Can you rebase this on |
|
Thanks for your contribution to Homebrew (and patience)! Without people like you submitting PRs we couldn't run this project. You rock! |
|
Just a heads up, it looks like there are newer versions of both patches than the ones we currently apply. Also, the patch for https://bugs.winehq.org/show_bug.cgi?id=14939 was purportedly committed, so we may need to stop applying it to As for https://bugs.winehq.org/show_bug.cgi?id=34166, it looks like the maintainer doesn't want to fix what he views as a macOS bug (although it may not be). Apple has engineers, and it's beyond me why he doesn't describe the bug to them at bugreport.apple.com, but we should test using the more recent patch in the meantime. |
No description provided.