code-server 4.0.1 #92582
Closed
code-server 4.0.1 #92582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrewTestBot
added
bump-formula-pr
jsjoeio
commented
Jan 5, 2022
jsjoeio
commented
Jan 5, 2022
==> FAILED
Full audit code-server --online --git --skip-style output
code-server:
* Binaries built for a non-native architecture were installed into code-server's prefix.
The offending files are:
/opt/homebrew/Cellar/code-server/4.0.1/libexec/vendor/modules/code-oss-dev/node_modules/@parcel/watcher/prebuilds/darwin-x64/node.napi.glibc.node (x86_64)
Error: 1 problem in 1 formula detectedHmm...any suggestions on how to fix this? |
|
You could try deleting them on ARM, since they shouldn't be run -- we don't guarantee that a user has Rosetta installed. |
|
Hmm...We added a step to delete them on ARM but the audit still failed. Any ideas @carlocab? |
carlocab
reviewed
Jan 6, 2022
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
|
Hmm...it failed but for different error here Is it upset with the |
carlocab
reviewed
Jan 7, 2022
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
carlocab
added
the
CI-no-fail-fast
|
On the bright side, I know how to fix this 😄 ==> FAILED
Full audit code-server --online --git --skip-style output
code-server:
* Binaries built for a non-native architecture were installed into code-server's prefix.
The offending files are:
/usr/local/Cellar/code-server/4.0.1/libexec/vendor/modules/code-oss-dev/node_modules/@parcel/watcher/prebuilds/darwin-arm64/node.napi.glibc.node (arm64) |
carlocab
approved these changes
Jan 8, 2022
|
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created with
brew bump-formula-pr.Notes to self
It looks like VS Code switched to using
@parcel/watcherfor their file system watcher in October 2021.@parcel/watcherincludes all the binaries in the npm package: darwin, linux, and win32 which appears to be causing this build issue for us.We think we can fix it by modifying our formula to delete the non-native binaries after running
yarn install