Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish prebuilds to npm #34

Merged
merged 8 commits into from Jun 19, 2020
Merged

Publish prebuilds to npm #34

merged 8 commits into from Jun 19, 2020

Conversation

DeMoorJasper
Copy link
Member

This PR switches to using prebuildify and publishes prebuilds on npm as well as GitHub, this reduces the need to run install scripts and to have an internet connection to install this package

Closes #30
Closes #26

@height
Copy link

height bot commented Mar 17, 2020

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

You can also use "Close T-X" to automatically close a task when the pull request is merged.

@mischnic
Copy link
Member

mischnic commented Apr 6, 2020

I barely know how this works

I guess after the source-map endeavour, you know this better than I do 😄

@DeMoorJasper
Copy link
Member Author

Not entirely sure why CI is failing, will have look at it at some point if I don't forget

@mischnic
Copy link
Member

mischnic commented Apr 6, 2020

The Node servers are currently not working correctly: nodejs/node#32683

@DeMoorJasper
Copy link
Member Author

DeMoorJasper commented Apr 6, 2020

@mischnic thanks for looking that up, would've expected azure to have a cache/proxy for things like that but apparently not

@@ -42,10 +42,9 @@ jobs:
- script: npm run prebuild
displayName: Test prebuild

- ${{ if startsWith(variables['Build.SourceBranch'], 'refs/tags/v') }}:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to publish the artifacts if we're not on a release tag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have to, just seemed useful to always store it in azure devops in case we want to download the prebuilds and test it or something

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not compile native bindings on install Unable to install parcel@next without internet access
3 participants