New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish prebuilds to npm #34
Conversation
|
I guess after the source-map endeavour, you know this better than I do 😄 |
Not entirely sure why CI is failing, will have look at it at some point if I don't forget |
The Node servers are currently not working correctly: nodejs/node#32683 |
@mischnic thanks for looking that up, would've expected azure to have a cache/proxy for things like that but apparently not |
@@ -42,10 +42,9 @@ jobs: | |||
- script: npm run prebuild | |||
displayName: Test prebuild | |||
|
|||
- ${{ if startsWith(variables['Build.SourceBranch'], 'refs/tags/v') }}: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to publish the artifacts if we're not on a release tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have to, just seemed useful to always store it in azure devops in case we want to download the prebuilds and test it or something
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok, sure.
This PR switches to using prebuildify and publishes prebuilds on npm as well as GitHub, this reduces the need to run install scripts and to have an internet connection to install this package
Closes #30
Closes #26