-
-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
psalm 4.18.1 #92696
psalm 4.18.1 #92696
Conversation
|
I'll have a look later. It's probably something that has to be solved on Psalm's side. |
See vimeo/psalm#7329 |
557bfae
to
a902f99
Compare
The problem has been resolved upstream and a new release 4.18.1 has been issued. However, that release produces warnings on PHP 8.1 (vimeo/psalm#7314). Because of that, I have added a wrapper script (similar to what we have done for the |
CI is 🟢 |
I don't think we should add a wrapper script for that. It runs just fine, you just get some deprecation messages that upstream is already aware of. |
Are you sure about that? I'm using that formula to install Psalm locally and those error messages are dumped into the console everytime I run Psalm, which is a bit annoying. Alternatively, we could have the wrapper script change the error level before running Psalm. This way we would not pin the PHP version and the deprecation warnings would be silenced on PHP 8.1. |
All the more reason to push upstream for a new version. Anything we can avoid patching in brew we should avoid. |
a902f99
to
e70848a
Compare
Very well, I've reverted the wrapper script. 🙂 |
🤖 A scheduled task has triggered a merge. |
Thanks @derrabus! |
This error still persist and make Psalm unusable in some frontend/editors/applications like PHPstorm. because the error message popups constantly. |
@Trurl101 I think, you should report this to the Psalm project instead. |
Created with
brew bump-formula-pr
.