Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psalm 4.18.1 #92696

Closed
wants to merge 1 commit into from
Closed

psalm 4.18.1 #92696

wants to merge 1 commit into from

Conversation

derrabus
Copy link
Contributor

@derrabus derrabus commented Jan 7, 2022

Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` php PHP use is a significant feature of the PR or issue labels Jan 7, 2022
@chenrui333
Copy link
Member

Uncaught Error: Class "Composer\InstalledVersions" not found in phar:///opt/homebrew/Cellar/psalm/4.18/bin/psalm/src/Psalm/Internal/CliUtils.php:116
Stack trace:
#0 phar:///opt/homebrew/Cellar/psalm/4.18/bin/psalm/src/Psalm/Internal/Cli/Psalm.php(188): Psalm\Internal\CliUtils::requireAutoloaders('/opt/homebrew/L...', false, 'vendor')
#1 phar:///opt/homebrew/Cellar/psalm/4.18/bin/psalm/src/Psalm/Internal/IncludeCollector.php(31): Psalm\Internal\Cli\Psalm::Psalm\Internal\Cli{closure}()
#2 phar:///opt/homebrew/Cellar/psalm/4.18/bin/psalm/src/Psalm/Internal/Cli/Psalm.php(189): Psalm\Internal\IncludeCollector->runAndCollect(Object(Closure))
#3 phar:///opt/homebrew/Cellar/psalm/4.18/bin/psalm/psalm(7): Psalm\Internal\Cli\Psalm::run(Array)
#4 /opt/homebrew/Cellar/psalm/4.18/bin/psalm(14): require('phar:///opt/hom...')
#5 {main}
(Psalm (unknown version) crashed due to an uncaught Throwable)

@chenrui333 chenrui333 added test failure CI fails while running the test-do block CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jan 7, 2022
@derrabus
Copy link
Contributor Author

derrabus commented Jan 7, 2022

I'll have a look later. It's probably something that has to be solved on Psalm's side.

@derrabus
Copy link
Contributor Author

derrabus commented Jan 7, 2022

See vimeo/psalm#7329

@derrabus derrabus changed the title psalm 4.18 psalm 4.18.1 Jan 8, 2022
@derrabus
Copy link
Contributor Author

derrabus commented Jan 8, 2022

The problem has been resolved upstream and a new release 4.18.1 has been issued. However, that release produces warnings on PHP 8.1 (vimeo/psalm#7314). Because of that, I have added a wrapper script (similar to what we have done for the php-cs-fixer formulae) to make sure Psalm is executed with PHP 8.0 until that problem has been resolved as well.

@derrabus
Copy link
Contributor Author

derrabus commented Jan 9, 2022

CI is 🟢

@SMillerDev
Copy link
Member

I don't think we should add a wrapper script for that. It runs just fine, you just get some deprecation messages that upstream is already aware of.

@derrabus
Copy link
Contributor Author

derrabus commented Jan 9, 2022

Are you sure about that? I'm using that formula to install Psalm locally and those error messages are dumped into the console everytime I run Psalm, which is a bit annoying.

Alternatively, we could have the wrapper script change the error level before running Psalm. This way we would not pin the PHP version and the deprecation warnings would be silenced on PHP 8.1.

@SMillerDev
Copy link
Member

which is a bit annoying.

All the more reason to push upstream for a new version. Anything we can avoid patching in brew we should avoid.

@derrabus
Copy link
Contributor Author

Very well, I've reverted the wrapper script. 🙂

@chenrui333 chenrui333 removed the test failure CI fails while running the test-do block label Jan 11, 2022
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@chenrui333
Copy link
Member

Thanks @derrabus!

@derrabus derrabus deleted the bump-psalm-4.18 branch January 11, 2022 09:19
@Trurl101
Copy link

Trurl101 commented Aug 1, 2022

This error still persist and make Psalm unusable in some frontend/editors/applications like PHPstorm. because the error message popups constantly.

@derrabus
Copy link
Contributor Author

derrabus commented Aug 1, 2022

@Trurl101 I think, you should report this to the Psalm project instead.

@github-actions github-actions bot added the outdated PR was locked due to age label Sep 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. outdated PR was locked due to age php PHP use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants