Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update humbug/box #7314

Closed
weirdan opened this issue Jan 5, 2022 · 5 comments · Fixed by #8770
Closed

Update humbug/box #7314

weirdan opened this issue Jan 5, 2022 · 5 comments · Fixed by #8770
Labels
bug
Milestone
PHP 8.1

Comments

@weirdan
Copy link
Collaborator

weirdan commented Jan 5, 2022

Current box version produces deprecation warnings when the resulting phar is run on 8.1:

$ php vendor/psalm/phar/psalm.phar
PHP Deprecated:  Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///home/weirdan/src/psalm/issues/phar/vendor/psalm/phar/psalm.phar/.box/src/RequirementCollection.php on line 15
Deprecated: Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///home/weirdan/src/psalm/issues/phar/vendor/psalm/phar/psalm.phar/.box/src/RequirementCollection.php on line 15
PHP Deprecated:  Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///home/weirdan/src/psalm/issues/phar/vendor/psalm/phar/psalm.phar/.box/src/RequirementCollection.php on line 19
Deprecated: Return type of HumbugBox383\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///home/weirdan/src/psalm/issues/phar/vendor/psalm/phar/psalm.phar/.box/src/RequirementCollection.php on line 19
Target PHP version: 8.1 (inferred from current PHP version)
Scanning files...
Analyzing files...

░
------------------------------
                              
       No errors found!       
                              
------------------------------

Checks took 0.21 seconds and used 61.212MB of memory
Psalm was unable to infer types in the codebase
@psalm-github-bot
Copy link

Hey @weirdan, can you reproduce the issue on https://psalm.dev ?

@weirdan weirdan added the bug label Jan 5, 2022
@weirdan weirdan added this to the PHP 8.1 milestone Jan 5, 2022
@derrabus derrabus mentioned this issue Jan 8, 2022
Closed
@alies-dev
Copy link
Contributor

the same issue, very annoying

@sebastianbergmann sebastianbergmann mentioned this issue Apr 12, 2022
Closed
@albertborsos
Copy link

same issue here

@mikemix
Copy link

mikemix commented Aug 23, 2022

Same here, the issue is still annoying.

@BafS BafS mentioned this issue Nov 11, 2022
Open
@theodorejb
Copy link
Contributor

I'm also getting this error when I try to use the dev-master Psalm build with GitHub actions.

@weirdan weirdan mentioned this issue Nov 26, 2022
Merged
weirdan added a commit that referenced this issue Nov 26, 2022
@weirdan
Merge pull request #8770 from weirdan/upgrade-humbug-box
c3cc906 
Fixes #7606
Fixes #5399
Fixes #7314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
PHP 8.1
Development

Successfully merging a pull request may close this issue.

Upgrade humbug/box weirdan/psalm
5 participants
@weirdan @mikemix @theodorejb @alies-dev @albertborsos