chmlib: Support Apple Silicon

[nsmaciej]

The audit fails with the following, but I have no idea what to do about the license warning and there doesn't seem to be any text fixtures chm files for me to add new tests with.

chmlib:
  * 1: col 1: A `test do` test block should be added
  * Formula chmlib contains deprecated SPDX licenses: ["LGPL-2.1"].
    You may need to add `-only` or `-or-later` for GNU licenses (e.g. `GPL`, `LGPL`, `AGPL`, `GFDL`).
    For a list of valid licenses check: https://spdx.org/licenses/

---

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

[carlocab]

Thanks for the PR.

there doesn't seem to be any text fixtures chm files for me to add new tests with.

Can we try to do something with a non-existent chm file and check we get the error message and exit code we should be getting?

[carlocab]

This is LGPL-2.1-or-later, as indicated in the headers of the source files. For example, in chm_lib.c and chm_lib.h:

/***************************************************************************
 *                                                                         *
 *   This program is free software; you can redistribute it and/or modify  *
 *   it under the terms of the GNU Lesser General Public License as        *
 *   published by the Free Software Foundation; either version 2.1 of the  *
 *   License, or (at your option) any later version.                       *
 *                                                                         *
 ***************************************************************************/

[nsmaciej]

Unfortunately chmlib is not very informative when it comes to errors, chm_open is either successful or it returns NULL.
I added a simple test for that.

[nsmaciej]

Out of curiosity, what does "CI-no-bottles" imply?

[carlocab]

Thanks!

[carlocab]

Out of curiosity, what does "CI-no-bottles" imply?

It tells @BrewTestBot not to publish bottles if they merge this PR automatically. We don't want that as that discards all the older bottles. I've dispatched a workflow to add the ARM bottles separately to preserve the older ones:

https://github.com/Homebrew/homebrew-core/actions/runs/1685003961