Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go 1.7.5 #9304

Closed
wants to merge 1 commit into from
Closed

go 1.7.5 #9304

wants to merge 1 commit into from

Conversation

tsuna
Copy link
Contributor

@tsuna tsuna commented Jan 26, 2017

Created with brew bump-formula-pr.

@cblecker
Copy link
Contributor

The upstream patch block on line 18-23 needs to be removed from the stable section :)

@tsuna
Copy link
Contributor Author

tsuna commented Jan 26, 2017

Gosh, that'll teach me to skip building it – I'm already on go 1.8rc2 and just upgraded to 1.8rc3 and I couldn't find a way to convince homebrew to let me install 1.7.5 without uninstalling the 1.8* versions that I have (and would like to keep around).

@tsuna
Copy link
Contributor Author

tsuna commented Jan 26, 2017

OK, I amended my commit and I temporarily moved the 1.8* versions I had out of the way to be able to convince homebrew to build 1.7.5, so I can confirm it works.

Copy link
Contributor

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DomT4
Copy link
Member

DomT4 commented Jan 26, 2017

May wish to update the gotools hash in stable too. It's trailing behind the current 1.7 branch a bit, most recent commit seems to be 6220cba6419b2bf78aad19d85c347ecc0fda2b53.

@tsuna
Copy link
Contributor Author

tsuna commented Jan 26, 2017

I'd be happy to do that in a separate pull request.

@DomT4
Copy link
Member

DomT4 commented Jan 26, 2017

It'd be better to do it in this one, if we're gonna do it, otherwise you'll get some people pouring bottles with the older tools until CI rolls a new set of bottles with the newer tools. Given there's a Qt5 build in the CI queue currently this PR is a fair while off being green either way, alas.

Also bump up gotools to the latest commit in release-branch.go1.7.
@tsuna
Copy link
Contributor Author

tsuna commented Jan 26, 2017

Fair enough. Done.

@nijikon
Copy link
Contributor

nijikon commented Jan 27, 2017

You are awesome, thanks for your contribution! 🎉

@nijikon nijikon closed this in 7c3e39c Jan 27, 2017
@twexler twexler mentioned this pull request Feb 16, 2017
4 tasks
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants