-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go 1.7.5 #9304
go 1.7.5 #9304
Conversation
The upstream patch block on line 18-23 needs to be removed from the stable section :) |
Gosh, that'll teach me to skip building it – I'm already on go 1.8rc2 and just upgraded to 1.8rc3 and I couldn't find a way to convince homebrew to let me install 1.7.5 without uninstalling the 1.8* versions that I have (and would like to keep around). |
OK, I amended my commit and I temporarily moved the 1.8* versions I had out of the way to be able to convince homebrew to build 1.7.5, so I can confirm it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
May wish to update the |
I'd be happy to do that in a separate pull request. |
It'd be better to do it in this one, if we're gonna do it, otherwise you'll get some people pouring bottles with the older tools until CI rolls a new set of bottles with the newer tools. Given there's a Qt5 build in the CI queue currently this PR is a fair while off being green either way, alas. |
Fair enough. Done. |
You are awesome, thanks for your contribution! 🎉 |
Created with
brew bump-formula-pr
.