Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_formulae: only allow fork build cache usage for BrewTestBot forks. #1142

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

MikeMcQuaid
Copy link
Member

Maintainers are now encouraged to branch directly on homebrew-core.

Maintainers are now encouraged to branch directly on homebrew-core.
MikeMcQuaid added a commit to Homebrew/brew that referenced this pull request Jul 14, 2024
This will no longer be needed or used after the merge of:
Homebrew/homebrew-test-bot#1142
@Bo98
Copy link
Member

Bo98 commented Jul 14, 2024

BrewTestBot doesn't even have any forks anymore

@MikeMcQuaid
Copy link
Member Author

@Bo98 Yes but, if that changes in future: we should allow it. I think we should moving back to forks there so it doesn't need to have write permissions on homebrew-core at all.

@MikeMcQuaid MikeMcQuaid merged commit 3ff77bc into master Jul 14, 2024
4 checks passed
@MikeMcQuaid MikeMcQuaid deleted the test_formulae_only_brewtestbot_forks branch July 14, 2024 14:07
@MikeMcQuaid
Copy link
Member Author

Thanks @Bo98!

ctaintor pushed a commit to ctaintor/brew that referenced this pull request Sep 4, 2024
This will no longer be needed or used after the merge of:
Homebrew/homebrew-test-bot#1142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants