Skip to content
This repository
Browse code

Install Git contrib more sensibly

Make caveats refer to persistent locations.
  • Loading branch information...
commit fff60b5e5ec99882e0ea976de20fb3e72fab2cfe 1 parent 6fb81be
Max Howell authored August 24, 2011

Showing 1 changed file with 4 additions and 4 deletions. Show diff stats Hide diff stats

  1. 8  Library/Formula/git.rb
8  Library/Formula/git.rb
@@ -47,7 +47,7 @@ def install
47 47
     (share+'doc/git-core/contrib').install 'contrib/emacs'
48 48
 
49 49
     # Install contrib files to share/contrib
50  
-    (share).install 'contrib'
  50
+    (share/:git).install 'contrib'
51 51
 
52 52
     # These files are exact copies of the git binary, so like the contents
53 53
     # of libexec/git-core lets hard link them.
@@ -71,10 +71,10 @@ def caveats; <<-EOS.undent
71 71
       #{etc}/bash_completion.d
72 72
 
73 73
     Emacs support has been installed to:
74  
-      #{share}/doc/git-core/contrib/emacs
  74
+      #{HOMEBREW_PREFIX}/share/doc/git-core/contrib/emacs
75 75
 
76  
-    The rest of the "contrib" has been installed to:
77  
-      #{share}/contrib
  76
+    The rest of the "contrib" is installed to:
  77
+      #{HOMEBREW_PREFIX}/share/git/contrib
78 78
     EOS
79 79
   end
80 80
 end

3 notes on commit fff60b5

Richard Osborn

Comment on line 49 should say "share/git/contrib", no?

Max Howell
Owner

Proof that redundant comments are both stupid and a maintenance burden. LIke seriously, who added that comment? The code is perfectly clear.

Charlie Sharpsteen
Owner

I'm usually in the "moar comments!" camp. But yeah, WTF.

Please sign in to comment.
Something went wrong with that request. Please try again.