Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Commit

Permalink
Install Git contrib more sensibly
Browse files Browse the repository at this point in the history
Make caveats refer to persistent locations.
  • Loading branch information
mxcl committed Aug 24, 2011
1 parent 6fb81be commit fff60b5
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Library/Formula/git.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def install
(share+'doc/git-core/contrib').install 'contrib/emacs'

# Install contrib files to share/contrib
(share).install 'contrib'
(share/:git).install 'contrib'

# These files are exact copies of the git binary, so like the contents
# of libexec/git-core lets hard link them.
Expand All @@ -71,10 +71,10 @@ def caveats; <<-EOS.undent
#{etc}/bash_completion.d
Emacs support has been installed to:
#{share}/doc/git-core/contrib/emacs
#{HOMEBREW_PREFIX}/share/doc/git-core/contrib/emacs
The rest of the "contrib" has been installed to:
#{share}/contrib
The rest of the "contrib" is installed to:
#{HOMEBREW_PREFIX}/share/git/contrib
EOS
end
end

3 comments on commit fff60b5

@rosborn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on line 49 should say "share/git/contrib", no?

@mxcl
Copy link
Contributor Author

@mxcl mxcl commented on fff60b5 Aug 25, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proof that redundant comments are both stupid and a maintenance burden. LIke seriously, who added that comment? The code is perfectly clear.

@Sharpie
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm usually in the "moar comments!" camp. But yeah, WTF.

Please sign in to comment.