Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Install Git contrib more sensibly

Make caveats refer to persistent locations.
  • Loading branch information...
commit fff60b5e5ec99882e0ea976de20fb3e72fab2cfe 1 parent 6fb81be
@mxcl mxcl authored
Showing with 4 additions and 4 deletions.
  1. +4 −4 Library/Formula/git.rb
View
8 Library/Formula/git.rb
@@ -47,7 +47,7 @@ def install
(share+'doc/git-core/contrib').install 'contrib/emacs'
# Install contrib files to share/contrib
- (share).install 'contrib'
+ (share/:git).install 'contrib'
# These files are exact copies of the git binary, so like the contents
# of libexec/git-core lets hard link them.
@@ -71,10 +71,10 @@ def caveats; <<-EOS.undent
#{etc}/bash_completion.d
Emacs support has been installed to:
- #{share}/doc/git-core/contrib/emacs
+ #{HOMEBREW_PREFIX}/share/doc/git-core/contrib/emacs
- The rest of the "contrib" has been installed to:
- #{share}/contrib
+ The rest of the "contrib" is installed to:
+ #{HOMEBREW_PREFIX}/share/git/contrib
EOS
end
end

3 comments on commit fff60b5

@rosborn

Comment on line 49 should say "share/git/contrib", no?

@mxcl
Owner

Proof that redundant comments are both stupid and a maintenance burden. LIke seriously, who added that comment? The code is perfectly clear.

@Sharpie
Collaborator

I'm usually in the "moar comments!" camp. But yeah, WTF.

Please sign in to comment.
Something went wrong with that request. Please try again.