Correct way of installing phantomjs #11225
Conversation
…at his blog: http://ariya.ofilabs.com/2012/02/phantomjs-and-mac-os-x.html . It's a lot faster (does not require the installation of QT and the downloaded file is +50% smaller) .
|
Seems reasonable to me. |
|
Does this work on Leopard? If not, an error needs to be added. |
|
Hmm, I'm not sure, I'm running Snow Leopard, and the article says it runs on both Lion and Snow Leopard. |
|
Note that Phantom.js recommends not using Homebrew at all. |
|
Sure but I can't imagine he'd complain if we ship his binary. |
|
@adamv he doesn't recommends it because there wasn't a proper installation of phantomjs. |
|
As pointed out here http://ariya.ofilabs.com/2012/03/the-evolution-of-phantomjs-build-workflow.html:
I'll add the check for snow_leopard or greater. |
|
Looks good, thanks for taking care of this! Now I can recommend brew for PhantomJS Mac users :) One minor thing: Info.plist should be in the same place (see http://code.google.com/p/phantomjs/issues/detail?id=281), otherwise Dock icon might appear. Unfortunately Info.plist will be too generic to be placed in the $prefix/bin (and I don't have any solution for this). |
Install |
|
@Sharpie, just did that and it still does not work. |
|
@Sharpie this is what I did https://gist.github.com/2223256 , as you proposed, and still didn't work. |
|
I suggest solving the possible appearance of Dock icon as early as possible. Otherwise PhantomJS issue tracker/forum might receive the user's notice again and I don't like to answer "..because you are using Homebrew...". |
|
@fabiomcosta Your latest gist works for me. Force-push it here and I'll commit it. |
|
@MikeMcQuaid it works but the dock icon still shows up for me. Did it show up for you? |
|
The dock icon is meant to show up so that's good :) It shows up for me. |
:/ |
|
With it and the executable in libexec and the executable symlinked and run as "phantomjs" (rather than a direct path) it works for me. |
|
strange... whats your OS? I'm on Snow Leopard, doesn't work here :S the icon is showing. |
|
The icon is meant to show! Please just update the pull request. |
|
@MikeMcQuaid the icon is not meant to the shown, thats what is being requested on the the link that @ariya posted http://code.google.com/p/phantomjs/issues/detail?id=281 |
|
My apologies, I assumed that was a typo. I don't see any easy way of solving this and I think we just include it without it. @ariya feel free to tell them this is a limitation of the Homebrew version. |
|
Per the issue |
|
@nandub Info.plist is too generic to be put into the bin folder, doesn't look right... |
|
Agree, but this should do until someone can create a better plist. I'm not familiar with this type of files so I don't know what else to change or add. |
|
Disable the symlinking and see if it still works. If it does, we'll use that. |
|
That is the symlink of Info.plist from /usr/local/Cellar/phantomjs/1.5.0/bin to /usr/local/bin. |
|
@MikeMcQuaid from the gist @fabiomcosta created I forked it then I added the Info.plist symlink, per @ariya comment, he doesn't want to see the ghost icon in the Dock. |
|
"Disable the symlinking and see if it still works. If it does, we'll use that." If you remove the Info.plist symlink then the icon will show up in the Dock, this is what @ariya is trying to avoid. |
|
Then it looks like we either merge as-is with the dock icon problem or remove Phantom JS. @adamv @mxcl @Sharpie @mistydemeo @jacknagel @ariya Thoughts? |
|
Dock icon should not be a showstopper, it's annoying but not critical. If there is a way to show a message after the installation about the dock icon situation and give a link to the issue, that's a way to inform the user. |
|
@ariya here's how it shows ater installing: there you go, thank you guys for the help! |
|
@fabiomcosta Fabulous! :) |
|
Squashed and pushed. Thanks @fabiomcosta and @ariya! |
|
nice! |
|
@MikeMcQuaid Awesome, thanks! |
|
The current caveat re the dock icon: we could solve this by copying the Info.plist to the Cellar and then installing a wrapper script that calls the Cellar binary rather than symlinking....is there any reason not to do this? It works nicely. |
|
@jkp looks fine, it's worth a new ticket or issue. I'll try to do that when I get time. |
Use the upstream binaries to avoid building a copy of Qt. Fixes Homebrew#11225. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
|
@jkp If it works: pull request please :) |
|
The wrapper script fixes this issue in 10640ea @ariya @fabiomcosta. Thanks @ronny! |
|
Great! Sorry, I hadn't got round to this yet - thanks for getting to it first. |
|
++awesome |
|
Just happened to have some cycles to spare. Thanks guys! |
|
nice! thanks @ronny and @MikeMcQuaid |
Use the upstream binaries to avoid building a copy of Qt. Fixes Homebrew#11225. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Use the upstream binaries to avoid building a copy of Qt. Fixes Homebrew#11225. Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
This is the correct way of installing phantomjs according to Aryia, the project creator http://ariya.ofilabs.com/2012/02/phantomjs-and-mac-os-x.html . It's a lot faster too (does not require the installation of QT and the downloaded file is +50% smaller).
Also updates from 1.4.1 to 1.5.0