Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

python: Allow --with-brewed-tk. #17008

Closed
wants to merge 1 commit into from
Closed

python: Allow --with-brewed-tk. #17008

wants to merge 1 commit into from

Conversation

samueljohn
Copy link
Contributor

  • Fixes python build doesn't link with brew tk / tcl #16574.
  • Improve Tkinter test by actually calling Tk()
  • Check for /Library/Frameworks/Tk.framework no longer needed.
  • Also remove Tk.framework check from python3.rb
  • Fix PYTHONFRAMEWORKDIR so that python-config --ldflags is useful.

@samueljohn
Copy link
Contributor Author

@MikeMcQuaid I had to open a new PR since I already deleted my old one. Now it works - the fix was easy.

@samueljohn samueljohn mentioned this pull request Jan 11, 2013
Closed
@MikeMcQuaid
Copy link
Member

Don't we need to do a similar patch for Python3?

@samueljohn
Copy link
Contributor Author

Python3 has the right flags:

python3.3-config --ldflags
-L/homebrew/Cellar/python3/3.3.0/Frameworks/Python.framework/Versions/3.3/lib/python3.3/config-3.3m -ldl -framework CoreFoundation -lpython3.3m

Python3 with a brewed tkinter would be another pull request.

@samueljohn
python: Allow --with-brewed-tk.
90f5168 
- Fixes Homebrew#16574.
- Improve Tkinter test by actually calling Tk()
- Check for /Library/Frameworks/Tk.framework no longer needed.
- Also remove Tk.framework check from python3.rb
- Fix PYTHONFRAMEWORKDIR so that `python-config --ldflags` is useful.
@samueljohn
Copy link
Contributor Author

@adamv sadly, removed the little 🐍

@samueljohn
Copy link
Contributor Author

@MikeMcQuaid let's try again please. Python3 won't break this time.

@adamv adamv closed this in 3defd78 Jan 15, 2013
@derekbrokeit
Copy link
Contributor

I tested this for program that requires brewed-tk (fails with apple tk) and it seems to work as expected! Thanks!

@tomyun tomyun mentioned this pull request Jan 17, 2013
Closed
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python build doesn't link with brew tk / tcl
4 participants
@samueljohn @MikeMcQuaid @derekbrokeit @adamv