-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
libtommath, libtomcrypt: new website for libtom project #43907
Conversation
mirror "https://distfiles.macports.org/libtomcrypt/crypt-1.17.tar.bz2" | ||
sha256 "e33b47d77a495091c8703175a25c8228aff043140b2554c08a3c3cd71f79d116" | ||
head "https://github.com/libtom/libtomcrypt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a .git
on the end of this URL.
Repo URLs fixed.
|
Bump... can this be pulled in? Previous issues are fixed and checks pass. |
D'oh! I'll check that out. |
Known issue: #43906; it's failing on 10.10 and 10.11. Can we just merge this website fix since it's not a regression, and deal with the build failure under the other issue? |
Not a good idea to update that, as the owner of libtom.net is currently not reachable and I don't know when this will change. |
How about now? It looks like libtom.net has the same contents as libtom.org now, and libtom.org is back online. Should we update this with links in to the new libtom.org site layout? |
Yes, libtom.net and libtom.org are functional now. |
Regarding the site layout, yes that will be the one you want to update your links to. |
Closes #45063. Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
Cool. I've revised and rebased this PR to use libtom.net and reflect the new site structure and GitHub releases. Works for me locally. Look good? Download URLs from GitHub are fine for us, as long as they're for tagged releases, like you're doing here. The new If these new URLs work out, I'll try to add a couple little tests as part of this PR so the formulae pass our CI. |
@apjanke LGTM when 💚 |
Would be good to pull bottles here when you merge. The |
No bottles (at least for libtomcrypt), due to outstanding issue #43906, which breaks the build on 10.10 and 10.11. (Forgot about that when I was talking about the formulae passing CI.) I think the thing to do is just merge this anyway and deal with the build failure separately: this URL fix will at least let brew-using devs download the files and attempt the build so they can debug and fix it. |
Ah, alright. Feel free in that case! |
STATUS: Don't merge yet; status of upstream sites is unclear.
Per their website, now at www.libtom.net: