diff-so-fancy 0.3.0 (new formula) #49040
Conversation
| url "https://github.com/stevemao/diff-so-fancy/archive/v0.1.2.tar.gz" | ||
| sha256 "fa4ac51368ba6b942c6b346117e5f72cabb00ea3c29f834e3c4ca80972e19502" | ||
|
|
||
| depends_on "gnu-sed" |
There was a problem hiding this comment.
Ah, run time, looking at the inreplace below.
There was a problem hiding this comment.
Yep, run time. The inreplace avoids need for default names install flag, and avoids issues if already installed without it.
There was a problem hiding this comment.
Would be good to make a feature request to be able to use BSD sed.
There was a problem hiding this comment.
@MikeMcQuaid Not likely to be worked on/accepted, the author (@paulirish) says in so-fancy/diff-so-fancy#25 "OS X sed is crap".
|
CI fail reason, not clear from the log, is that the repo is not 30+ days old. With ~2K stars though it's hopefully clearly not going anywhere. |
| @@ -0,0 +1,18 @@ | |||
| class DiffSoFancy < Formula | |||
| desc "builds on the good-lookin' output of diff-highlight" | |||
There was a problem hiding this comment.
I changed the desc to "Good-lookin' diffs with diff-highlight and more" on npm and "Unfancy git-diff" on GitHub
Merged PR so-fancy/diff-so-fancy#25 prefers `gsed` over `sed`, so no need to replace ocurrences to `gsed` here.
|
Aye. We don't need the inreplace. Thanks for already taking care of that, @OJFord We'll work to remove the dependency on gnu-sed, in the short term. |
|
Does this need updating to |
|
@DomT4 Hadn't seen that, will update now. |
|
@DomT4 yes, but by waiting for another 25+ days we will be sure to make several releases |
|
To be honest, unless any other maintainers object, I'm fairly content to waive the 30 day requirement here. There's enough Issues and PRs being created by people who aren't upstream developers to convince me there's significant community interest in the project. |
|
Oh well, that's great :) thanks :) |
|
Should we wait for so-fancy/diff-so-fancy#55 though? Would remove the |
|
Well, there's no massive rush. I'll at least give fellow maintainers a chance to comment on the 30 day issue; they object when I act like a Dictator 😜. |
|
Hi guys, just letting you know that we have moved the project to an org. |
OJFord
changed the title
|
Looks like |
|
@stevemao I don't think it's a bug your end, it's just something changed that meant it didn't work with the symlink I was using before. I didn't dig deeper because this seemed a better solution anyway. @DomT4 As far as I can tell from the changelog, it's just administrative stuff - CI, readme - updating anyway though. |
OJFord
changed the title
Closes Homebrew#49040. Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
Closes so-fancy/diff-so-fancy#21.