Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create and submit a brew formula #21

Closed
OJFord opened this issue Feb 10, 2016 · 12 comments
Closed

Create and submit a brew formula #21

OJFord opened this issue Feb 10, 2016 · 12 comments

Comments

@OJFord
Copy link
Member

OJFord commented Feb 10, 2016

Repo more than meets the star/fork requirements. Most Mac users would probably prefer a pure-brew install than a brew+npm install.

brew install gnu-sed --with-default-names && npm install -g diff-so-fancy would become brew install diff-so-fancy. You could even include the git configuration in the formula.

@stevemao
Copy link
Member

I think homebrew is already available but not pointing to this repo.
No

@OJFord
Copy link
Member Author

OJFord commented Feb 10, 2016

Do you know the name? I don't get any results for brew search diff-so-fancy.

@paulirish
Copy link
Member

yah i'm not seeing it either.

image

I'm OK with having this available via homebrew, though i've never maintained a brew package before. seems likely higher friction pushing to npm.

@paulirish
Copy link
Member

@OJFord i dont think we'd get the default-names applied if we set it as a dependency. So we'd have to rely on gsed and sniff for that first. Slightly more complicated, but probably fine.

@OJFord
Copy link
Member Author

OJFord commented Feb 10, 2016

@paulirish Hmm, good point, I've never tried to do anything analagous so I couldn't say either way for sure. (See Homebrew/homebrew#35948).

As a workaround though, it could be done in the install block with a system call. I expect (hope) brew maintainers would be happy with that until an alternative exists though.

@OJFord
Copy link
Member Author

OJFord commented Feb 10, 2016

Oh! I thought of a better solution: you could use inreplace to change instances of sed in the script to gsed; then the dependency needs no flags, right?

@anshul
Copy link
Contributor

anshul commented Feb 10, 2016

Or something like this could work? - #25

@OJFord
Copy link
Member Author

OJFord commented Feb 10, 2016

@anshul That might be more robust. If the brew install with default name flag doesn't alias gsed as well (I'd hope so, but have no idea) then I suppose my above suggestion fails if gnu-sed already installed. (I checked the formula, it does symlink gsed -> sed, so it should be fine).

@OJFord
Copy link
Member Author

OJFord commented Feb 16, 2016

Closed via Homebrew/legacy-homebrew#49040.

@OJFord OJFord closed this as completed Feb 16, 2016
@stevemao
Copy link
Member

Thanks again @OJFord 😄

@stevemao
Copy link
Member

We need to add docs on how to install via Homebrew.

@stevemao stevemao reopened this Feb 16, 2016
@OJFord
Copy link
Member Author

OJFord commented Feb 16, 2016

@stevemao No worries :)

So for install instructions, I'd suggest just replacing the "on Mac, get gnu-sed with brew" with "on Mac, install via brew: brew install diff-so-fancy".

Can PR if you want [Have PR'd because I'm not doing anything else], but if you'd prefer to just get the wording how you'd like it yourself rather than review mine that's 👍 too!

stevemao added a commit that referenced this issue Feb 16, 2016
updates Mac install guide for brew; closes #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants