New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect gsed and use it if it exists #25
Conversation
@stevemao Squashed the changes into a single commit. |
Is it common to symlink |
This is such a common pattern on osx/homebrew that it's pretty muh universal on most osx installs. |
Sorry, I read your comment wrong. Edited mine. I think, everyone is served better if npm install just works out of the box on a typical osx install. Recommending overriding the apple sed command could leave other commands that depend on the apple installation in a bad shape. |
Looks like ports also installs a gsed. http://apple.stackexchange.com/a/166593 |
I'm fine with this. I'll see what other people think. |
Yup. This is good. Osx sed is crap but some people won't want to replace it and that's fine. |
SED=sed | ||
if hash gsed 2>/dev/null; then | ||
SED=gsed | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this a one liner?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
@paulirish Does that one liner look fine? |
Yup! Ace. |
Detect gsed and use it if it exists
Merged PR so-fancy/diff-so-fancy#25 prefers `gsed` over `sed`, so no need to replace ocurrences to `gsed` here.
No description provided.