Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Require brew link --force for keg-only brews #13349

Closed
adamv opened this issue Jul 11, 2012 · 12 comments
Closed

Require brew link --force for keg-only brews #13349

adamv opened this issue Jul 11, 2012 · 12 comments
Assignees
@adamv
Labels
features

Comments

@adamv
Copy link
Contributor

adamv commented Jul 11, 2012

Proposal: make keg-only brews harder to brew link.
@jacknagel
Copy link
Contributor

Good idea.

@mistydemeo
Copy link
Member

A --forceful +1. I've spoken to some users who didn't realize it was a bad idea despite the current indicators, so making them do a more explicit brew link would help.

@adamv
Copy link
Contributor Author

adamv commented Jul 12, 2012

Hmm, how do I get a formula from a keg.

@adamv
Copy link
Contributor Author

adamv commented Jul 12, 2012

Proof-of-concept here: https://github.com/adamv/homebrew/compare/link

@mistydemeo
Copy link
Member

Corollary: --force already does something in brew ln, so it wouldn't be possible to do a non-destructive link of a keg-only formula.

ln -f is young enough I think it's safe to rename; may be better to rename that to --overwrite and use --force for this.

@MikeMcQuaid
Copy link
Member

+1

@mistydemeo
Copy link
Member

@adamv If you're planning on going ahead with this, I'll change --force in my brew ln update to --overwrite (or similar).

@adamv
Copy link
Contributor Author

adamv commented Jul 17, 2012

I still plan on doing this when I get time.

@adamv
Copy link
Contributor Author

adamv commented Sep 4, 2012

Did brew ln get updated?

@adamv
Copy link
Contributor Author

adamv commented Oct 20, 2012

Ping?

mistydemeo added a commit that referenced this issue Oct 21, 2012
@mistydemeo
brew ln --force is now brew ln --overwrite
f52ebe5 
* Renames --force to --overwrite, freeing up brew ln --force for #13349
* Changes --dry-run to preview linking by default, rather than
  overwriting. An overwrite dry-run can be simulated via both
  --dry-run --overwrite
* Adds some basic Keg tests
@mistydemeo
Copy link
Member

Pushed as f52ebe5 (which also adds the expanded --dry-run behaviour we talked about!)

Sorry I kinda fell of the face of the earth around then.

Sharpie pushed a commit to Sharpie/homebrew that referenced this issue Oct 22, 2012
@mistydemeo
brew ln --force is now brew ln --overwrite
0f6ae11 
* Renames --force to --overwrite, freeing up brew ln --force for Homebrew#13349
* Changes --dry-run to preview linking by default, rather than
  overwriting. An overwrite dry-run can be simulated via both
  --dry-run --overwrite
* Adds some basic Keg tests
snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this issue Dec 17, 2012
@mistydemeo
brew ln --force is now brew ln --overwrite
8543d15 
* Renames --force to --overwrite, freeing up brew ln --force for Homebrew#13349
* Changes --dry-run to preview linking by default, rather than
  overwriting. An overwrite dry-run can be simulated via both
  --dry-run --overwrite
* Adds some basic Keg tests
@ghost ghost assigned adamv Jan 17, 2013
@adamv adamv mentioned this issue Jan 23, 2013
Closed
@samueljohn
Copy link
Contributor

Ok, saying it here again: brew link $(brew list) should link all that are not keg_only (but perhaps show a warning like "Skipping x...".

@adamv adamv closed this as completed in dd5ea24 Jan 30, 2013
@nnarhinen nnarhinen mentioned this issue Feb 4, 2013
Merged
Sharpie pushed a commit to Sharpie/homebrew that referenced this issue Feb 19, 2013
@adamv
Require --force to link keg-only.
c0c95e5 
Closes Homebrew#13349.
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adamv adamv

Labels
features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@adamv @MikeMcQuaid @jacknagel @samueljohn @mistydemeo