-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
qt 4.8.6 failed to build on 10.6 #28859
Comments
Try and make this change to the formula file and see if that fixes it: - args << "-no-3dnow" if superenv?
+ args << '-no-3dnow' << '-no-ssse3' if superenv? |
@MikeMcQuaid that change made it work for me here. |
@dakcarto ☝️ Perhaps we should enable it just for 10.6 (although I've a feeling we perhaps did that before). |
worked for me as well - thanks for such a quick workaround |
@MikeMcQuaid wrote:
Sure. I don't know enough about SSE (or what's supposedly fixed in the latest 4.8.6, but that doesn't work for 10.6) to really have a valid opinion here. Haven't compiled under 10.6 yet. @ryanshaw @a5sk4s |
it was on 10.6.8 for me |
I misspoke earlier, I'm on 10.9.2 but also could not compile qt 4.8.6. That tweak mentioned by @MikeMcQuaid fixed it for me. Apologies for the confusion. |
Here's the Qt source commit: https://qt.gitorious.org/qt/qt/commit/1c0a1ebba12c9c1fa02117b9a017c4ed3f7cd7c3 Seems with the cascading, that adding |
Ok, this patch fixed the compiling issue I had on 10.7.5. Odd, though, because the same |
the commit 37c8e4b breaks the build on OS X 10.9.2:
when I revert the changes of this commit the build works. |
@andihit Try this formula with included patch for that issue (noted above). However, did not have the issue here on 10.9.2 with current formula.
|
@dakcarto I'm guessing it'll depend on your hardware whether you have this problem or not. Could you submit this patch to Qt's Gerrit: https://codereview.qt-project.org/ |
Qt Gerrit patch set uploaded for review and bug report added. |
Perfect, thanks @dakcarto. Happy to apply that patch in a PR too now it's reported. You're a model open-source citizen 👼 |
Thanks guys, works perfectly now. |
@Sean1708 Thanks for the feedback. What worked for you? The current formula in main tap, or did you specifically try the one I noted here? |
@MikeMcQuaid Do you mind taking some time to review the Qt bug report? If there is a flaw in my logic, or Could be that I just don't know enough about how SS(S)E optimization is triggered at the compiler level. Otherwise, I think my argument/patch in the report is pretty sound. |
The commit has broken qt for me on 10.9.2 |
@GuillaumeDIDIER Can you try @dakcarto's patch. |
@dakcarto Think you're probably fighting a losing battle there. Can we just specify more configure arguments when using superenv to e.g. disable SSE4.2? |
Can anyone still having issues here (@justinclift and @robsonpeixoto too) confirm if this fixes them for you: - args << "-no-3dnow" << "-no-ssse3" if superenv?
+ args << "-no-3dnow" << "-no-ssse3" << "-no-sse4.1" << "-no-sse4.2" if superenv? |
I suspect given the resistance of getting this patch merged upstream we may need to remove the |
@MikeMcQuaid same problem
|
I guess we should perhaps just apply @dakcarto's patch in the mean time until we work out a better solution. |
Things still barf on OSX 10.7.5 when using this line:
@dakcarto's patch worked though. |
@MikeMcQuaid Regarding the addition of I really have no clue as to the logic of why the patch is not being applied upstream. I can't think of anything to add to the upstream bug report, or any other way to fix it. Removing all |
People may want to test out #28985 as it seems to fix all these issues. |
@MikeMcQuaid That PR fixes the build issues here on 10.7.5. Thanks! |
@MikeMcQuaid That PR fixes the build issues here on 10.9.2. Thanks! |
@dakcarto Sorry I didn't get back to you earlier, the main tap worked for me on the day I posted that comment. |
Fixes for this just went into master, let us know if there are any further issues. |
@jacknagel On 10.8.5 I was seeing the "error: use of undeclared identifier '_mm_blendv_epi8'" issue. After pulling the latest master the build worked. |
Yep, worked here too. qt 4.8.6 compiled fine. |
@jacknagel Thanks for this. |
Upgrading qt failed, most likely with the error '_mm_alignr_epi8 not declared in this scope'.
Gist (as per the troubleshooting checklist) is here: https://gist.github.com/Sean1708/ea4873c3899bcd4606bc
The text was updated successfully, but these errors were encountered: