-
-
Notifications
You must be signed in to change notification settings - Fork 11.4k
Conversation
Now, it uses pkg-config to find system png library.
What is the source of this patch? Can it be sent upstream? |
I am the author of this patch. I have used m4 code from the same file (search for exr library) and have changed it for png. |
To use autoreconf this needs deps on autotools for Xcode 4.3+, e.g. if MacOS.xcode_version.to_f >= 4.3
depends_on "automake" => :build
depends_on "libtool" => :build
end |
…lation using clang compiler.
@jacknagel, you are right. I checked it on clean mac os installation. |
Do I need something more to do with this request so it will be approved? Or there is some approval procedure which I don't know? |
Nope, someone just has to find time to review it. |
Okay, as I thought. Sorry for impatient bumping, thanks anyway. |
It looks like this is unnecessary if ENV.x11 is added to the formula - I'll fix this when I push a separate clang-related fix. |
@mistydemeo I did not known about ENV.x11. Unfortunately, I cannot test it now, but, if it will help to link against system libpng - it will be great. Much better than my heavy patching solution. |
Argh, I did it again - made a comment from different account. @PIlin is me, sorry for confusion. |
Fixed in 87afdd0 - please let me know if this doesn't work for you! |
@mistydemeo It worked, thanks. |
Now, it uses pkg-config to find system png library.