Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

devil: png support #11656

Closed
wants to merge 2 commits into from
Closed

devil: png support #11656

wants to merge 2 commits into from

Conversation

pashkoff
Copy link

Now, it uses pkg-config to find system png library.

Now, it uses pkg-config to find system png library.
@adamv
Copy link
Contributor

adamv commented Apr 14, 2012

What is the source of this patch? Can it be sent upstream?

@pashkoff
Copy link
Author

I am the author of this patch. I have used m4 code from the same file (search for exr library) and have changed it for png.
Problem is that the project seems to be dead - last commit to the repo was in 2010, last closed bug was in 2010. So, I'm not sure that patch can be sent to the devil project upstream.

@jacknagel
Copy link
Contributor

To use autoreconf this needs deps on autotools for Xcode 4.3+, e.g.

if MacOS.xcode_version.to_f >= 4.3
  depends_on "automake" => :build
  depends_on "libtool" => :build
end

@pashkoff
Copy link
Author

@jacknagel, you are right. I checked it on clean mac os installation.
Also, I have found that library fails to compile using clang++.

@pashkoff
Copy link
Author

Do I need something more to do with this request so it will be approved? Or there is some approval procedure which I don't know?

@jacknagel
Copy link
Contributor

Nope, someone just has to find time to review it.

@pashkoff
Copy link
Author

Okay, as I thought. Sorry for impatient bumping, thanks anyway.

@mistydemeo
Copy link
Member

It looks like this is unnecessary if ENV.x11 is added to the formula - I'll fix this when I push a separate clang-related fix.

@PIlin
Copy link

PIlin commented May 21, 2012

@mistydemeo I did not known about ENV.x11. Unfortunately, I cannot test it now, but, if it will help to link against system libpng - it will be great. Much better than my heavy patching solution.

@pashkoff
Copy link
Author

Argh, I did it again - made a comment from different account. @PIlin is me, sorry for confusion.

@mistydemeo
Copy link
Member

Fixed in 87afdd0 - please let me know if this doesn't work for you!

@pashkoff
Copy link
Author

@mistydemeo It worked, thanks.

chrismetcalf pushed a commit to chrismetcalf/homebrew that referenced this pull request Jun 18, 2012
Sharpie pushed a commit to Sharpie/homebrew that referenced this pull request Sep 12, 2012
snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants