This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
Add prompts for linkapps #12619
Closed
Add prompts for linkapps #12619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,3 +31,5 @@ | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| puts "Finish linking. Find the links under ~/Applications." | |||
There was a problem hiding this comment.
s/Finish linking/Finished linking/
|
I think two messages is overkill; the second one, modulo the comment I made, should be sufficient. |
|
You are right. That is better. |
|
Make the change, squash to a single commit, then |
People may suppose that the links will generated under /Applications instead of ~/Applications. Add prompts to guide users.
|
Wow, so that github can update automatically~ |
|
Applied, thanks. |
Sharpie
pushed a commit
to Sharpie/homebrew
that referenced
this pull request
Jun 18, 2012
Closes Homebrew#12619. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
chrismetcalf
pushed a commit
to chrismetcalf/homebrew
that referenced
this pull request
Jun 18, 2012
Closes Homebrew#12619. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
eproxus
pushed a commit
to eproxus/homebrew
that referenced
this pull request
Jul 18, 2012
Closes Homebrew#12619. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
snakeyroc3
pushed a commit
to snakeyroc3/homebrew
that referenced
this pull request
Dec 17, 2012
Closes Homebrew#12619. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People may suppose that the links will generated under /Applications instead of ~/Applications.
Add prompts to guide users.