Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

drizzle: remove LD/CPPFLAGS #15998

Closed
wants to merge 1 commit into from
Closed

drizzle: remove LD/CPPFLAGS #15998

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 12, 2012

boost149 is keg only.

@ghost
Copy link
Author

ghost commented Nov 13, 2012

boost149, it does not work yet with latter versions.

@adamv
Copy link
Contributor

adamv commented Nov 13, 2012

I'll try this on Lion when I get a chance.

On Snow Leopard, getting an unrelated:

drizzled/drizzled.cc: In function ‘void drizzled::create_pid_file()’:
drizzled/drizzled.cc:417: error: ‘O_CLOEXEC’ was not declared in this scope

@ghost
Copy link
Author

ghost commented Nov 18, 2012

SL doesn't support O_CLOEXEC

@adamv
Copy link
Contributor

adamv commented Nov 18, 2012

So should we mark this as no longer supporting Snow Leopard?

@ghost
Copy link
Author

ghost commented Nov 18, 2012

There is patch: https://bugs.launchpad.net/gearmand/+bug/980114 commen # 6 I can prepare that.

@ghost
Copy link
Author

ghost commented Nov 18, 2012

Actual patch: https://launchpadlibrarian.net/102708957/fcntl.patch Do you think it is worth patching ?

@jacknagel
Copy link
Contributor

Someone could let them know that on 10.6, FD_CLOEXEC is defined rather than O_CLOEXEC.

@ghost
Copy link
Author

ghost commented Nov 18, 2012

Brian Aker is the one who started drizzle fork, so If he hasn't seen fit to include it in last 6 months I do not think I can persuade him any more :-).

@ghost
Copy link
Author

ghost commented Nov 18, 2012

well on closer inspection it is actually bug about Gearman so I might stand some chance.

@adamv
Copy link
Contributor

adamv commented Nov 18, 2012

Probably no one on Snow Leopard is trying to use Drizzle or we would have gotten more bug reports, so I'm OK deprecating SL support on this instead of patching, and pointing people upstream.

@ghost
Copy link
Author

ghost commented Nov 18, 2012

Updated.

@adamv adamv closed this in 8e7ef43 Nov 18, 2012
manboubird pushed a commit to manboubird/homebrew that referenced this pull request Nov 25, 2012
Closes Homebrew#15998.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
manboubird pushed a commit to manboubird/homebrew that referenced this pull request Nov 25, 2012
Closes Homebrew#15998.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
snakeyroc3 pushed a commit to snakeyroc3/homebrew that referenced this pull request Dec 17, 2012
Closes Homebrew#15998.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants