added optional depends to libsndfile formula

[yvanvds]

This adds optional config options to libsndfile for flac, libvorbis and libogg. As a sound developer, i really assume most users will not want a libsndfile without support for at least libogg.

[mistydemeo]

Hm, does the configure script require any switches to turn support for those libraries on? I tried installing with all of those options active, but the resulting dylib and the libsndfile executables don't link against any of those libraries. A brief test with sndfile-play wasn't able to open a .ogg file.

[yvanvds]

Ah, I thought it was only me, not knowing how this was supposed to work. In fact, when i compile libsndfile myself i can just type ./configure without any options and it will compile with libogg etc. if they are found on the system.

With homebrew, after adding these options, i tested with

brew -v install --with-flac --with-libogg --with-libvorbis libsndfile

and that worked out ok. I guessed this was how it was supposed to go, after reading your answer on my bug report.

[mistydemeo]

Yeah, that's what I expected too. I find it strange it didn't detect them for me.

checking for flac >= 1.2.1 ... yes
checking for ogg >= 1.1.3 ... no
checking for vorbis >= 1.2.3 ... no
checking for vorbisenc >= 1.2.3 ... no

So it looks like it found flac but not ogg or vorbis, which is weird because I have all of them installed. It worked after I removed and then reinstalled libogg and libvorbis, so... I don't have a good answer there?

At any rate, if they're all-or-nothing, it's probably better just to enable all of them unconditionally. They build pretty speedily anyway. Do you mind changing that, amending your commit, and repushing to Github? That'll update the pull request.

(It would also be great if your commit message mentioned the software in the title, like "libsndfile: depends_on flac, libogg and libvorbis")

[yvanvds]

ok, i think that should be what you asked for. I tested the installation and everything works now. And like i said before, i think most programmers will want libsndfile to support ogg anyway.

[rdvdijk]

I have installed flac, libogg and libvorbis, but libsndfile still says it can't find any of them. Strange..

checking for flac >= 1.2.1 ... no
checking for ogg >= 1.1.3 ... no
checking for vorbis >= 1.2.3 ... no
checking for vorbisenc >= 1.2.3 ... no

Any idea how to fix that? If I download libsndfile and do a ./configure all of these can be found..

Edit: nevermind, spoke to soon. I applied your patch and that works fine! Thanks.

[adamv]

@mistydemeo is this ready to go?