Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Install setuptools in Python formulae now that distribute has been merged in. #21017

Closed
wants to merge 1 commit into from
Closed

Install setuptools in Python formulae now that distribute has been merged in. #21017

wants to merge 1 commit into from

Conversation

Julian
Copy link
Contributor

@Julian Julian commented Jul 5, 2013

Here's a pull request for #20959 (which contains the rationale in case the merger is not familiar with why this is now appropriate).

We may want to consider adding a caveat telling people that they may want to manually uninstall old versions that they have installed of distribute if you guys would like that, since they can cause issues.

@samueljohn
Copy link
Contributor

let me do a few checks first, okay?
Will merge this then...

@ghost ghost assigned samueljohn Jul 6, 2013
@samueljohn
Copy link
Contributor

Anything bad about directly going to 0.8?
https://pypi.python.org/pypi/setuptools/0.8

@samueljohn
Copy link
Contributor

Biggest change is probably discussed in this thread:
Eggs are back. I still have to read the details.
http://bugs.python.org/setuptools/issue33

@Julian
Copy link
Contributor Author

Julian commented Jul 7, 2013

No, nothing bad, I pushed this out just before 0.8 was released :).

@samueljohn
Copy link
Contributor

Can you please update to the 0.8 then?

@samueljohn
Copy link
Contributor

@Julian when I brew rm python and brew install python (with the setuptools 0.7 as in this pull request), I get an error when I try to pip install ...:

ValueError: A 0.7-series setuptools cannot be installed with distribute. Found one at /usr/local/lib/python2.7/site-packages/setuptools-0.7.7-py2.7.egg

How can we provide a clean upgrade path for our users?

@Julian
Copy link
Contributor Author

Julian commented Jul 7, 2013

Can you please update to the 0.8 then?

Yes, as soon as I get a moment.

@Julian when I brew rm python and brew install python (with the setuptools 0.7 as in this pull request), I get an error when I try to pip install ...:

That's what I meant about adding a caveat. You presumably have old versions of distribute in your site-packages directory. We can tell users to remove those themselves (or I guess attempt to remove them ourselves).

@adamv
Copy link
Contributor

adamv commented Jul 7, 2013

Two upstream updates on the same day?

Should we hold off for a bit longer just in case there is an 0.8.1?

@samueljohn
Copy link
Contributor

We are not in a hurry here since the current version still works nicely with pip install.
Of course we will update eventually (soon) but lets assure upgrading is smooth.

@tbekolay
Copy link

Just wanted to add that I was having an error with brew install python because distribute was giving me an OSError, and changing the formula to use a recent setuptools instead solved the issue. Having this PR merged would have fixed my problem.

@samueljohn
Copy link
Contributor

OSError is most likely due to an older setuptools sitting around in /Library/Python/2.7/site-packages (that has been installed via sudo.

@samueljohn
Copy link
Contributor

For python.rb I just updated the formula to use setuptools 0.8. For the other formulae, I am happy if you could update this pull request.

@samueljohn
Copy link
Contributor

I updated to setuptools 0.9.5 for python.rb and python3.rb.

@samueljohn
Copy link
Contributor

@Julian do you want to update this PR to do the same for PyPy (which I have not yet done)?

@samueljohn
Copy link
Contributor

Or perhaps its better to open a new PR for this, okay? Ping me once done. Closing this now.

@samueljohn samueljohn closed this Jul 17, 2013
@samueljohn
Copy link
Contributor

Thanks you!

@Julian
Copy link
Contributor Author

Julian commented Jul 17, 2013

Sure thing. Thanks for being on top of this, I'll send a PR for PyPy in an
hour or so.
On Jul 17, 2013 9:23 AM, "Samuel John" notifications@github.com wrote:

@Julian https://github.com/Julian do you want to update this PR to do
the same for PyPy (which I have not yet done)?


Reply to this email directly or view it on GitHubhttps://github.com//pull/21017#issuecomment-21112115
.

@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants