csvfix 1.3

[mattcg]

Even though 1.5 is currently available, this is difficult to compile on Mac as it requires g++ 4.7. 1.3 is the latest available version which compiles with g++ 4.2.

[adamv]

Warning: Formula reports different SHA1: 8a0303e5c43062cf348e992c52058bd125cb16a8
SHA1: 43cd65482b3fee2ced7b7ad888938918b02e3cd6
SHA256: 34e86456439fd9c565993b18777ce2ce074d17bac8309f5418e9d89e2e7620bc

[mattcg]

What utility d'you use to get the sha1 on the commandline?

If I use curl to download the file then here are the results using openssl and shasum:

$ curl https://csvfix.googlecode.com/archive/version-1.3.zip -o version-1.3.zip
$ openssl sha1 version-1.3.zip
4910cd78ad783ca1dfd9d090e49ab33623422140
$ shasum version-1.3.zip 
4910cd78ad783ca1dfd9d090e49ab33623422140  version-1.3.zip

What am I doing wrong?

[adamv]

Usually I update the URL, remove the SHA1, and do brew fetch -f foo.

In this case, is the archive tarball stable or generated? Doesn't Hg like to generate archives with timestamps (which change the sha each time)?

[mattcg]

Darn it. You're right, it's generated.

Switched to the official bitbucket download, which seems stable.

[adamv]

Looks good, except for a small audit nitpick:

Error: 1 problems in 1 formulae
csv-fix:
 * stable version 1.3 is redundant with version scanned from URL

[mistydemeo]

it requires g++ 4.7. 1.3 is the latest available version which compiles with g++ 4.2.

It's inconvenient for users, but we do provide the option to build using g++ 4.7 or greater.

Does cvs-fix 1.5 not build with clang in C++11 mode?

[mattcg]

Does cvs-fix 1.5 not build with clang in C++11 mode?

Unfortunately, no. See the discussion here.

Consequently, for the time being, CSVfix requires a compiler that has more support for C++2011 than the Mac OS X 'clang' compiler provides.

Csvfix at head is fixed for compilation on Mac, it's just that this fix came after the 1.5 release. I'm going to file an issue with the author to ask whether he can release 1.6.

[mattcg]

Filed.