qwt: designer plugin fix and new build options #26152
Conversation
| # update designer plugin linking back to qwt framework/lib | ||
| # this is specific to Homebrew and probably (?) doesn't need patched upstream | ||
| def patches | ||
| DATA |
There was a problem hiding this comment.
Should use inreplace in that case.
|
Updated as per recommendations. |
|
Any other edits needed? |
| depends_on 'qt' | ||
|
|
||
| def install | ||
| inreplace 'qwtconfig.pri' do |s| | ||
| # change_make_var won't work because there are leading spaces | ||
| s.gsub! /^\s*QWT_INSTALL_PREFIX\s*=(.*)$/, "QWT_INSTALL_PREFIX=#{prefix}" | ||
| s.sub! /#(QWT_CONFIG\s*\+= QwtMathML)/, "\\1" if build.with? "qwtmathml" |
There was a problem hiding this comment.
Is editing files the only way to enable such things? You should be able to set this argument from the command-line (if I remember my QMake correctly).
|
Any updates here? |
|
Sorry about the delayed work on these. I started on creating a shared location for Qt4 plugins, but am unsure if that is the best approach. I guess the questions are:
The same issue for |
|
@jacknagel @adamv Updated the branch. @MikeMcQuaid wrote:
Since I tried using the Same quandary for #26153 as well. |
| end | ||
|
|
||
| args = ['-config', 'release', '-spec'] | ||
| args = %W[-config release -spec] |
There was a problem hiding this comment.
Please don't change stuff like this; I think the previous version is far more readable to people less experienced with Ruby. I've been writing Ruby daily for a few years now and I still forget what most of these do.
|
Concerning symlinking the Qt Designer plugin to If that is a reasonable approach, I will draft a PR related to it. |
|
@dakcarto Yeh, you could just create that directory, set up the symlinks in Qt itself and let the various formulae link into it. |
|
Sorry about the delay with this and thanks! |
Designer plugin now works. Added option to build as libs instead of framework. Added qwtmathml option, which is now not built by default.