solr: add startup plist #32069
solr: add startup plist #32069
Conversation
| @@ -18,6 +18,9 @@ def script; <<-EOS.undent | |||
| def install | |||
| libexec.install Dir["*"] | |||
| (bin+"solr").write script | |||
| (var+'logs'+name).mkpath | |||
| (etc+name).mkpath | |||
| (etc+name).install Dir[libexec+'example/multicore'] unless (etc+name+'multicore').exist? | |||
There was a problem hiding this comment.
You don't need the Dir[] or the exist? check.
There was a problem hiding this comment.
Dir[] removed.
I need the exist? because the example files are installed to /usr/local/solr/multicore and are supposed to be changed by the user when adding new/configuring new cores. Configuration that should persist on upgrades.
|
Sorry for the delay (work, kids, ...)... I addressed @MikeMcQuaid s comments and pushed a new version. |
|
The test fails. It looks as if the test bot is unable to reach Github. |
|
|
||
| -Djetty.port=48983 | ||
| EOS | ||
| end |
There was a problem hiding this comment.
Can we slim these down a lot (perhaps entirely)? The longer they are the less likely any of them will be read.
There was a problem hiding this comment.
Sure. Removing the caveats entirely is because the best choice then, because there is really nothing interesting left then.
|
I have been busy with work and family and haven't had much time to follow up on this pull request. There has been a lot of comments and I possible and I got a bit confused along the way. So I have been reading a bit up on Homebrews inner details and spent some thinking about what I actually wanted to do and how best to do it. Besides providing a So I have ended up with adding a I used to have some "unless" condition on the part about the configuration stuff and @MikeMcQuaid pointed out that it was unnecessary. Previous attempts of mine didn't work without the "unless" part but this approach with copying instead of moving (which was the wrong thing to do in the first place) works like a charm. |
|
The first test build failed because 4.9.0 was no longer downloadable - I've added a commit upgrading it to 4.10.0. |
| def post_install | ||
| # Copy the multicore example configuration into | ||
| # /usr/local/etc/solr/multicore as a configuration starting point. | ||
| cp_r libexec+"example/multicore", etc+name+"multicore" |
There was a problem hiding this comment.
Again, use etc.install here.
|
This PR needs rebased on |
|
ping, can we get this rebased, please? |
Added a plist startup like was previously done in [solr36](https://github.com/Homebrew/homebrew-versions/commit/4fa8b9b3c8f37667f1d993a53a6b9da383d87179) at Homebrew/homebrew-versions#366.
|
Rebased. Sorry for the long the delay. The updated version of Solr made a lot of the stuff I tried to do in post_install redundant. So now this is just adding a plist. |
Added a plist startup like was previously done in solr36 at Homebrew/homebrew-versions#366.
Defaults to running Solr on port 8984 so it can run in parallel with solr36 which runs on port 8983.