Change dependency for CasperJS

[cosmo0920]

CasperJS does not support PhantomJS 2.0 now.

[n1k0]

+1

[DomT4]

Sadly, Homebrew almost always doesn't have mandatory non-core dependencies in the core. Your PR may be complicated by that rule.

[cosmo0920]

Sadly, Homebrew almost always doesn't have mandatory non-core dependencies in the core. Your PR may be complicated by that rule.

Oh, this is sad for me.... 😢

Hmm..., what would be the best thing to do?

[DomT4]

Not sure. One of the maintainers will make a final decision when they see this PR. I guess there could be a case for vendoring the dependency rather than using the one in versions.

[MikeMcQuaid]

Yeh, we'll need to work something out here. Does it actually depend on PhantomJS from Homebrew or just any PhantomJS? Do they have a timescale for 2.0 support?

[cosmo0920]

Does it actually depend on PhantomJS from Homebrew or just any PhantomJS?

Currently, CasperJS depends on PhantomJS 1.x. It does not support PhantomJS 2.0.x.
So, I decided to lock PhantomJS dependency. I selected PhantomJS 1.9.8.

This dependency issue is already addressed in casperjs/casperjs#1137.
But I didn't see any progress for a long time about this issue.

Do they have a timescale for 2.0 support?

CasperJS has a milestone for 2.0 which is scheduled to support PhantomJS 2.0.
Milestone is discussed in https://github.com/n1k0/casperjs/issues/1177.

Hmm, it seems to be needed a bunch of time to support PhantomJS 2.0, at least until 2016.
see: https://github.com/n1k0/casperjs/issues/1177#issuecomment-77358014

[cosmo0920]

@n1k0 please comment in this PR if my understanding is something wrong.

[n1k0]

Does it actually depend on PhantomJS from Homebrew or just any PhantomJS?

As @cosmo0920 said, Casper doesn't support 2 at this moment, and requires PhantomJS 1.8.2<v<2.

Do they have a timescale for 2.0 support?

Casper can't officially support PhantomJS 2 officially until they officially release a Linux version (so we can add it to our CI build matrix). Also, Many parts of CasperJS codebase should be upgraded in order to fully support it anyway, which will indeed take some time.

[DomT4]

Proposed fix in #38681.

[cosmo0920]

Thanks, @DomT4! Your proposal is more Homebrewish way!

[paazmaya]

👍 and 🍪