Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

casperjs: vendor phantomjs182 #38681

Closed
wants to merge 1 commit into from
Closed

casperjs: vendor phantomjs182 #38681

wants to merge 1 commit into from

Conversation

DomT4
Copy link
Member

@DomT4 DomT4 commented Apr 15, 2015

Closes #38632

@DomT4 DomT4 mentioned this pull request Apr 15, 2015
Closed
@DomT4
Copy link
Member Author

DomT4 commented Apr 15, 2015

Failure looks unrelated. It's failing to find the stable version of Casper to test when installing devel, which is kind of obvious.

Error: casperjs: failed
No such file or directory - /usr/local/Cellar/casperjs/1.0.4/bin/casperjs

Doing it outside of brew test is fine:

CasperJS version 1.1.0-beta3 at /usr/local/Cellar/casperjs/1.1-beta3/libexec, using phantomjs version 1.8.2

n1k0
n1k0 reviewed Apr 16, 2015
View reviewed changes
Library/Formula/casperjs.rb
depends_on 'phantomjs'
# https://github.com/Homebrew/homebrew/pull/38632
resource "phantomjs" do
url "https://phantomjs.googlecode.com/files/phantomjs-1.8.2-macosx.zip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this enforce using PhantomJS 1.8.2 only? Could we rather set 1.9.8 which is the latest 1.x version CasperJS actually supports, with many improvements over 1.8.2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. CasperJS disagrees with you on supporting 1.9.8. Install 1.9.8, run CasperJS, and:

CasperJS 1.0.x does not support PhantomJS version >= 1.9

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you wanted to play around after installation though, you could just remove the export PATH line from bin/casperjs.

@MikeMcQuaid
Copy link
Member

It's just the devel test that's failing. Would be good to have that fixed before we merge.

@DomT4
Copy link
Member Author

DomT4 commented Apr 17, 2015

Hilariously, it looks like the test breakage is down to case-sensitivity. The stable version outputs its PhantomJS version as PhantomJS version and the devel version seems to pump out the same thing as phantomjs version. Sigh. Will cut down the expected output a little more to dance around that.

@cosmo0920
Copy link
Contributor

Awesome!

@MikeMcQuaid
Copy link
Member

Thanks @DomT4!

@DomT4 DomT4 deleted the friendlyghost branch April 19, 2015 15:24
@indera
Copy link

indera commented Aug 22, 2015

Edit: casperjs works with phantomjs 1.9.8

Should we change the download link to https://github.com/ariya/phantomjs/archive/1.9.8.zip?

this is what I tested

$ brew install casperjs --develop
$ casperjs
==> CasperJS version 1.1.0-beta3 at /usr/local/Cellar/casperjs/1.1-beta3/libexec, using phantomjs version 1.8.2

$ brew install homebrew/versions/phantomjs198
$ brew link --overwrite phantomjs198
$ cd /usr/local/Cellar/casperjs/1.1-beta3/libexec/phantomjs/bin
$ mv phantomjs phantomjs_1.8.2
$ ln -s /usr/local/bin/phantomjs phantomjs

new casperjs

$ casperjs
==> CasperJS version 1.1.0-beta3 at /usr/local/Cellar/casperjs/1.1-beta3/libexec, using phantomjs version 1.9.8

@DomT4
Copy link
Member Author

DomT4 commented Aug 22, 2015

#43180

@indera
Copy link

indera commented Aug 22, 2015

@DomT4 👍

@Homebrew Homebrew locked and limited conversation to collaborators Jul 10, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DomT4 @MikeMcQuaid @cosmo0920 @indera @n1k0