Add Yubico Universal Two-Factor Libraries and U2F PAM Module #43676
Conversation
dlo
force-pushed
the
u2f
branch
2 times, most recently
from
5641d78
to
1362f94
Compare
| depends_on "json-c" => :build | ||
|
|
||
| def install | ||
| args = ["--prefix=#{prefix}"] |
There was a problem hiding this comment.
If there's just one arg inline it. system "./configure", "--prefix=#{prefix}"
Thanks
|
Thanks for your work on this, Dan. Excited for it to land in Homebrew! 🎉 |
|
Thanks Justin! |
|
@MikeMcQuaid Unfortunately, the PAM module itself (pam_u2f) cannot be tested without a human--the only way to ensure installation has succeeded is to have a physical U2F USB key and update your PAM configuration accordingly. The best I can think of is to copy the format set by pam_yubico (https://github.com/Homebrew/homebrew/blob/f2eada5f48597e0d688aaa36907a8ba29bf62f40/Library/Formula/pam_yubico.rb#L36) However, I was able to add tests for libu2f-host and libu2f-server. Let me know if there's anything else here that needs to be addressed. :) |
|
All tests now passing. |
dlo
changed the title
|
@MikeMcQuaid @DomT4 Any more updates needed here? Would love to get this merged in! |
| def caveats; <<-EOS.undent | ||
| To use the U2F for PAM authentication, specify the full path to the module (#{lib}pam/pam_u2f.so) in a PAM configuration. You can find all PAM configurations in /etc/pam.d. | ||
|
|
||
| For further installation instructions, please visit https://developers.yubico.com/pam-u2f/#installation. |
There was a problem hiding this comment.
Can you ensure that these lines are wrapped at 80 characters, thanks!
|
@MikeMcQuaid Should be good to go here. :) |
|
Ping on the |
|
Checking out comments now...thought I had finished up things on my end but new things came up. |
dlo
force-pushed
the
u2f
branch
2 times, most recently
from
805ea73
to
309cae7
Compare
|
@bfontaine @DomT4 @MikeMcQuaid just updated to use upstream release |
| desc "Provides an easy way to use U2F-compliant authenticators with PAM." | ||
| homepage "https://developers.yubico.com/pam-u2f/" | ||
| url "https://github.com/Yubico/pam-u2f/archive/pam_u2f-1.0.3.tar.gz" | ||
| version "1.0.3" |
There was a problem hiding this comment.
You can remove this line; Homebrew extracts the version from the URL.
|
@bfontaine @DomT4 @MikeMcQuaid Can we please cap the rounds of comments please? I have no problem making this last round of changes but at this point I'm getting feedback on things that could have been mentioned months ago. The seemingly neverending back and forth is making this tiresome for me. Can we agree that after this round is complete, we're good to go? |
|
@dlo These two style comments should be the last ones; if you check the build everything went fine except for the |
|
@dlo Yup, should be good to ship after that. I'm sorry that it's seemed never-ending but a bunch of these things are flagged for you by tools you can run locally ( |
|
Ping? |
|
@bfontaine Thanks for the reminder--totally got lost on my radar. Just updated with changes. Thanks! |
|
@bfontaine Alright, tests are green and all comments addressed. :) |
|
@DomT4 @bfontaine @MikeMcQuaid Yay! Thanks all. Glad to see this finally merged. :) |
|
🎉 |
Contains three formula:
Thanks!