This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
openssl: add 'enable-ssl-trace' option #45250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -16,6 +16,7 @@ class Openssl < Formula | |||
|
|
|||
| option :universal | |||
| option "without-check", "Skip build-time tests (not recommended)" | |||
| option "with-trace", "Build with enable-ssl-trace" | |||
There was a problem hiding this comment.
Would you mind using a more understandable text for people who are not familiar with the ./configure options? Something like “Enable support for the -trace option on s_client” for example.
The enable-ssl-trace build flag allows the -trace option to be passed to openssl s_client, which shows verbose, human-readable trace output of protocol messages.
dconnolly
force-pushed
the
openssl-enable-trace
branch
from
2bef79b
to
5d4e391
Compare
|
Updated option description and squashed. |
|
Since we're testing everything in a sandbox now, a bunch of dependents are failing: http://bot.brew.sh/job/Homebrew%20Pull%20Requests/35262/#showFailuresLink If you wanted to fix those up that would be super, otherwise we'll get to them when we can. |
ghost
mentioned this pull request
|
AFAICT this isn't in the 1.0.2 branch but we could do this for 1.1.0. Let me know if I'm wrong! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enable-ssl-trace build flag allows the -trace option to be passed to
openssl s_client, which shows verbose, human-readable trace output of
protocol messages. https://www.openssl.org/docs/manmaster/apps/s_client.html