This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
git: add "--with-pcre" option #8929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,6 +35,11 @@ class Git < Formula | |||
|
|
|||
| ENV['BLK_SHA1']='1' if ARGV.include? '--with-blk-sha1' | |||
|
|
|||
| if ARGV.include? '--with-pcre' | |||
| ENV['USE_LIBPCRE']='yes' | |||
| ENV['LIBPCREDIR']=Formula.factory('pcre').prefix | |||
There was a problem hiding this comment.
It should work to just say ENV['LIBPCREDIR'] = HOMEBREW_PREFIX.
There was a problem hiding this comment.
Oops!
I've fixed it.
Thank you for your information.
|
Pulled. |
Sharpie
pushed a commit
to Sharpie/homebrew
that referenced
this pull request
Sep 12, 2012
Closes Homebrew#8929. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
casallas
pushed a commit
to casallas/homebrew
that referenced
this pull request
Sep 13, 2012
Closes Homebrew#8929. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
snakeyroc3
pushed a commit
to snakeyroc3/homebrew
that referenced
this pull request
Dec 17, 2012
Closes Homebrew#8929. Signed-off-by: Jack Nagel <jacknagel@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git's subcommand "grep" has a "-P" option to use Perl-compatible regexp(PCRE) patterns.
But it requires git to be linked against libpcre.
So this patch makes it possible to use it by linking against libpcre.