Adding RMI #29
Merged
Adding RMI #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I haven't closely examined nor tested yet (hope that @ajgates42 can take a closer look ), but overall looks good! I think having |
|
Thanks @jg-you, this looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in issue #27, this PR adds the reduced mutual information (introduced in this preprint).
Some remarks: I defined
get_log_omegaas a private function. It calculates the log of the number of contigency table with fixed row and column margins, and it didn't sound like something that needed to be exposed. I can move it if you think that it is better.I also did not use the function
nmito calculate the mutual information, because we use an "exact version" of the MI, calculated combinatorically, that only equals the more standard MI in the limit of large clusters. (see Eq.~(24) of our preprint).