Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonnative fixes and improvements -> Dev #153

Merged
merged 5 commits into from
Feb 10, 2022

Conversation

DanieleDiBenedetto
Copy link
Collaborator

@DanieleDiBenedetto DanieleDiBenedetto commented Jan 10, 2022

Must restore marlin and poly commit dependency once merged

@DanieleDiBenedetto DanieleDiBenedetto changed the base branch from development to in_memory_lazy_smt January 12, 2022 16:38
@albertog78 albertog78 requested review from nicholas-mainardi and removed request for albertog78 February 3, 2022 14:58
r1cs/gadgets/std/src/fields/nonnative/reduce.rs Outdated Show resolved Hide resolved
r1cs/gadgets/std/src/fields/nonnative/tests.rs Outdated Show resolved Hide resolved
r1cs/gadgets/std/src/fields/nonnative/tests.rs Outdated Show resolved Hide resolved
Copy link

@UlrichHaboeck75 UlrichHaboeck75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the comments I addressed, ok.

nicholas-mainardi and others added 4 commits February 9, 2022 14:25
…s' of github.com:HorizenOfficial/ginger-lib into Optimize-non-native-field-mul-for-pseudo-mersenne-primes
…d-mul-for-pseudo-mersenne-primes

Optimize non native field mul for pseudo mersenne primes
@DanieleDiBenedetto DanieleDiBenedetto changed the base branch from in_memory_lazy_smt to development February 10, 2022 08:55
@DanieleDiBenedetto DanieleDiBenedetto merged commit 8de1ad7 into development Feb 10, 2022
@DanieleDiBenedetto DanieleDiBenedetto deleted the nonnative_doc branch March 23, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants