Development #87
Merged
Development #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated yarn.lock, decimals in max send and tx fee
vherus
approved these changes
Mar 22, 2019
| @@ -508,7 +509,7 @@ class SendPage extends React.Component { | |||
| <Button | |||
| modifier='quiet' | |||
| onClick={ | |||
| () => this.handleSendValueChange({ target: { value: (this.props.context.value - (this.state.sendFee / 100000000)).toPrecision(8) } })} | |||
| () => this.handleSendValueChange({ target: { value: this.props.context.value == 0 ? 0 : ((this.props.context.value * 100000000- 10000)/100000000).toPrecision(8)} })} | |||
There was a problem hiding this comment.
Let's tidy Arizen up one tiny task at a time. I'd really like to move this stray 100000000 into a constant named something like SATOSHI_MULTIPLIER so we can simplify things a bit more. It'll never change, but I think we'll sleep a little sounder knowing that the math definitely has the right amount of zero's in every case.
megaluck
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.