-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update unit test data, Add totalAmount to cert #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, left a few comments to consider, but no show stoppers. Let me know what you decide, and I'll approve when ready
@cronicc It looks like we need to run the test with |
@yurikoinaba Addressed in #67, in the long run it might be better to switch to a version of webpack that doesn't have that issue (if there is one). |
isFromBackwardTransfer
tobackwardTransfer
and removepubKeyHash
from certificate output (to match block explorer response. ex https://explorer-testnet.horizen.io/api/tx/410a983c24f14bc0c2bef11c3274f399b99f32235742da8b3eca1ebb2986146f)test/helper/formatCertificate.js
totalAmount
(The total value of the certificate in ZEN
) tocert