Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit test data, Add totalAmount to cert #65

Merged
merged 5 commits into from
Nov 5, 2021

Conversation

yurikoinaba
Copy link
Collaborator

@yurikoinaba yurikoinaba commented Oct 29, 2021

@yurikoinaba yurikoinaba changed the title Update unit test data Update unit test data, Add totalAmount to cert Oct 29, 2021
Copy link
Contributor

@loucaponi loucaponi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left a few comments to consider, but no show stoppers. Let me know what you decide, and I'll approve when ready

src/transaction.js Outdated Show resolved Hide resolved
src/certificate.js Outdated Show resolved Hide resolved
src/certificate.js Outdated Show resolved Hide resolved
@yurikoinaba
Copy link
Collaborator Author

@cronicc It looks like we need to run the test with export NODE_OPTIONS=--openssl-legacy-provider for Node v17
webpack/webpack#14532

@cronicc
Copy link
Member

cronicc commented Nov 1, 2021

@cronicc It looks like we need to run the test with export NODE_OPTIONS=--openssl-legacy-provider for Node v17 webpack/webpack#14532

@yurikoinaba Addressed in #67, in the long run it might be better to switch to a version of webpack that doesn't have that issue (if there is one).

@yurikoinaba yurikoinaba merged commit f058264 into development Nov 5, 2021
@yurikoinaba yurikoinaba deleted the yuriko/TOOLS-114 branch November 5, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants