Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thunderbird 102 ESR #24

Merged
merged 18 commits into from
Sep 28, 2022
Merged

Thunderbird 102 ESR #24

merged 18 commits into from
Sep 28, 2022

Conversation

HorlogeSkynet
Copy link
Owner

@HorlogeSkynet HorlogeSkynet commented Jul 14, 2022 •
edited
Loading

Description

  • Arkenfox v91.1 -> v102.1 migration for new ESR
  • Adds app.use_without_mail_account (v93)
  • Enforces mail.compose.warn_public_recipients.* preferences (v93)
  • Switches to mail.default_send_format to send plaintext email (v101)
  • Adds mail.biff.use_new_count_in_badge to template
  • Gets rid of mail.calendar-integration.opt-out & calendar.useragent.extra
  • Cleans outdated 0300 section documentation (related to auto-install)
  • Disables new calendar.extract.service.enabled preference
  • Adds mail.biff.show_alert and mail.biff.alert.show_* preferences
  • Removes unnecessary leading spaces in some documentation lines
  • Enforces mail.compose.add_link_preview
  • Enforces mailnews.message_display.disable_remote_image

How has this been tested ?

  • On Windows (Thunderbird v102.2.2)
  • On Linux (Thunderbird v102.2.0)

Types of changes :

  • Bug fix (non-breaking change which fixes an issue)
  • Typo / style fix (non-breaking change which improves readability)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist :

  • My changes looks good ;
  • I agree that my code may be modified in the future ;
  • My code follows the code style of this project (see .eslintrc.yml).

@HorlogeSkynet HorlogeSkynet added the enhancement New feature or request label Jul 14, 2022
@HorlogeSkynet HorlogeSkynet self-assigned this Jul 14, 2022
@HorlogeSkynet HorlogeSkynet mentioned this pull request Jul 14, 2022
Closed
@HorlogeSkynet HorlogeSkynet force-pushed the thunderbird/esr_102 branch 4 times, most recently from a38c4d6 to 8ae022d Compare July 23, 2022 13:53
@HorlogeSkynet HorlogeSkynet marked this pull request as ready for review July 23, 2022 13:55
Samuel FORESTIER added 12 commits August 24, 2022 10:22
Applies Arkenfox v91..v102 migration
4dc99eb 
> **WORK IN PROGRESS FOR ESR 102 : DO NOT USE IT AS IS**

Migration status :
    * updated README
    * updated header
    * updated index
    * updated sections
Allows Thunderbird to be used without any configured email account (v93)
39aaee7
Adds mail.compose.warn_public_recipients.* preferences
5a787eb 
* Adds `mail.compose.warn_public_recipients.threshold` with its default value
* Enables `mail.compose.warn_public_recipients.aggressive` to show an alert if previous setting warning has not be addressed (v93+)
Switches to mail.default_send_format to send plaintext email (v101)
5caedc0 
Thunderbird 101 replaced legacy `mail.default_html_action` and
`mailnews.sendformat.auto_downgrade` by `mail.default_send_format` new
preference to choose email sending format.

Whereas a proper "migration" is performed on first start, we stick to
plaintext email enforcement in this template, as done before.

See <https://bugzilla.mozilla.org/show_bug.cgi?id=1727493>.

> see #21
Adds mail.biff.use_new_count_in_badge to template (left to default)
fdcaf85
Gets rid of calendar.useragent.extra (removed in TB 78 ESR)
22efe76
Gets rid of mail.calendar-integration.opt-out (removed in TB 68 ESR)
5387c41
Cleans outdated 0300 section documentation (related to auto-install)
838529f
Disables new calendar.extract.service.enabled preference
03c8646
Adds mail.biff.show_alert and mail.biff.alert.show_* preferences
0abbda8
Applies Arkenfox v102.0..v102.1 migration
255ccd8
Removes unnecessary leading spaces in some documentation lines
f885b50
@Dupond
Copy link
Collaborator

Dupond commented Sep 2, 2022

Hi,

Thank you very much for your work!

I just wanted to mention that in my Thunderbird, the pref "app.use_without_mail_account" set to "true" causes the mail folders and the messages to be hidden. I use Thunderbird 102.2.0 in Arch Linux. It could be a Thunderbird bug, however...

@HorlogeSkynet
Copy link
Owner Author

Hi,

Hi @Dupond !

Thank you very much for your work!

Thank you, very appreciated.

I just wanted to mention that in my Thunderbird, the pref "app.use_without_mail_account" set to "true" causes the mail folders and the messages to be hidden. I use Thunderbird 102.2.0 in Arch Linux. It could be a Thunderbird bug, however...

Nice feedback, maybe an oversight from me. By looking at the source code again, this came up : https://searchfox.org/comm-esr102/rev/d9800535d0b488462c8ae64f7fe6647cc42535e1/mail/base/content/msgMail3PaneWindow.js#714-722

We might end up leaving this preference commented out in the template, for users not using TB for emails, but maybe for calendar, address books or even IM. What do you think about that ?

Bye 👋

PS : BTW, if by chance you are interested, this project definitely need maintainers/reviewers ! 🙂

@Dupond
Copy link
Collaborator

Dupond commented Sep 3, 2022

We might end up leaving this preference commented out in the template, for users not using TB for emails, but maybe for calendar, address books or even IM. What do you think about that ?

Seems nice!

PS : BTW, if by chance you are interested, this project definitely need maintainers/reviewers !

I don't have the time (nor the skill), unfortunately; sorry about that... You project is really nice, though; it's really useful; I like all the decisions you made about including some prefs or not. And I can imagine that reviewing the Arkenfox and the Thunderbird code regularly must ask a lot of time; I'm really sorry I can't help.

@Dupond Dupond mentioned this pull request Sep 4, 2022
Closed
3 tasks
@HorlogeSkynet
Copy link
Owner Author

HorlogeSkynet commented Sep 7, 2022 •
edited
Loading

I don't have the time (nor the skill), unfortunately; sorry about that... You project is really nice, though; it's really useful; I like all the decisions you made about including some prefs or not. And I can imagine that reviewing the Arkenfox and the Thunderbird code regularly must ask a lot of time; I'm really sorry I can't help.

Hey @Dupond,

Sorry for the delay.
By "maintainer" I didn't necessarily mean "developer", but also "reviewer" or "tester" (thus more or less what you've done here, that's why I wanted to propose you).
Indeed, this project is pretty much time consuming, and classically, there are daily new users (and the TB dev team has gone 🚀 lately with a rich roadmap), but with the same manpower as before over here.
(my) pull requests definitely need reviews and tests on other setups.

Feel free not to answer here, I just wanted to clarify what I meant previously 🙏
Bye 👋

@Dupond
Copy link
Collaborator

Dupond commented Sep 8, 2022

Well, I do use your thunderbird-user.js file on a daily basis, and I use Arch, which is a rolling release, and thus I will always test the last version of your project. So if it's just that, of course I'm OK to report any problem I may encounter ;)

Have a nice day!

@HorlogeSkynet HorlogeSkynet added this to IN PROGRESS in Thunderbird User.JS Sep 10, 2022
Samuel FORESTIER added 2 commits September 10, 2022 14:19
Restores two preferences in section 2700
902231e 
`privacy.antitracking.enableWebcompat` & `privacy.partition.serviceWorkers` are actually present in TB ESR 102.
Adds corresponding SETTING tag for mail.default_send_format
d778e6d
Dupond
Dupond approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@Dupond Dupond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the loooong delay! I've been really busy.

I've applied the last commits, and everything seems fine on my side! Thanx for the good work!

@HorlogeSkynet HorlogeSkynet merged commit 6798bda into master Sep 28, 2022
Thunderbird User.JS automation moved this from IN PROGRESS to DONE Sep 28, 2022
@HorlogeSkynet HorlogeSkynet deleted the thunderbird/esr_102 branch September 28, 2022 18:47
@HorlogeSkynet HorlogeSkynet mentioned this pull request Sep 30, 2022
Closed
HorlogeSkynet pushed a commit that referenced this pull request Oct 1, 2022
Workaround ETP Strict Mode lack of support in 102
9b83e3f 
In #24, we wrongly assumed that ETP Strict Mode was available in TB 102 (as it was for FF 102).

This patch aims to workaround this (security) issue by :

* Re-enabling FPI ;
* Re-enabling DNT header ;
* Restoring `network.cookie.cookieBehavior` tweak ;
* Re-enabling ETP with custom settings (including query parameter stripping) ;
* Re-dealing with persistent storage-related preferences (`2700`).

This increases divergence with Arkenfox upstream template.

> see #27
@HorlogeSkynet HorlogeSkynet mentioned this pull request Oct 1, 2022
Merged
5 tasks
HorlogeSkynet pushed a commit that referenced this pull request Oct 1, 2022
@HorlogeSkynet
Workaround ETP Strict Mode lack of support in 102
bae9719 
In #24, we wrongly assumed that ETP Strict Mode was available in TB 102 (as it was for FF 102).

This patch aims to workaround this (security) issue by :

* Re-enabling FPI ;
* Re-enabling DNT header ;
* Restoring `network.cookie.cookieBehavior` tweak ;
* Re-enabling ETP with custom settings (including query parameter stripping) ;
* Re-dealing with persistent storage-related preferences (`2700`).

This increases divergence with Arkenfox upstream template.

> see #27
HorlogeSkynet pushed a commit that referenced this pull request Oct 1, 2022
@HorlogeSkynet
Workaround ETP Strict Mode lack of support in 102
412ab90 
In #24, we wrongly assumed that ETP Strict Mode was available in TB 102 (as it was for FF 102).

This patch aims to workaround this (security) issue by :

* Re-enabling FPI ;
* Re-enabling DNT header ;
* Restoring `network.cookie.cookieBehavior` tweak ;
* Re-enabling ETP with custom settings (including query parameter stripping) ;
* Re-dealing with persistent storage-related preferences (`2700`).

This increases divergence with Arkenfox upstream template.

> see #27
HorlogeSkynet pushed a commit that referenced this pull request Oct 2, 2022
@HorlogeSkynet
Workaround ETP Strict Mode lack of support in 102
d8d79d6 
In #24, we wrongly assumed that ETP Strict Mode was available in TB 102 (as it was for FF 102).

This patch aims to workaround this (security) issue by :

* Re-enabling FPI ;
* Re-enabling DNT header ;
* Restoring `network.cookie.cookieBehavior` tweak ;
* Re-enabling ETP with custom settings (including query parameter stripping) ;
* Re-dealing with persistent storage-related preferences (`2700`).

This increases divergence with Arkenfox upstream template.

> see #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dupond Dupond Dupond approved these changes

Assignees

@HorlogeSkynet HorlogeSkynet

Labels
enhancement New feature or request
Projects
Thunderbird User.JS
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HorlogeSkynet @Dupond