Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Mark required fields as required for New Patient/Edit Patient #1915

Closed
jackcmeyer opened this issue Mar 18, 2020 · 2 comments · Fixed by #1932
Closed

Mark required fields as required for New Patient/Edit Patient #1915

jackcmeyer opened this issue Mar 18, 2020 · 2 comments · Fixed by #1932
Assignees
@alti21
Labels
🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
Version 2.0
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

🚀 Feature Proposal

Mark required fields with the *.

The following fields are required:

  • Given Name

Labels have the ability to be marked as required: https://components.hospitalrun.io/?path=/story/label--label.

Motivation

Fields that are required should be marked as required so the user is aware that the field is required before saving.
@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun Mar 18, 2020
@alti21
Copy link
Contributor

alti21 commented Mar 18, 2020

May I work on this?

@jackcmeyer jackcmeyer added 🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions patients issue/pull request that interacts with patients module labels Mar 18, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Mar 18, 2020
@jackcmeyer
Copy link
Member Author

I've assigned this to you @alti21!

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Mar 18, 2020
alti21 added a commit to alti21/hospitalrun-frontend that referenced this issue Mar 19, 2020
@alti21
fix(HospitalRun#1915): ark required fields as required for new/edit P…
b43facf 
…atient
@alti21 alti21 mentioned this issue Mar 19, 2020
Merged
@jackcmeyer jackcmeyer mentioned this issue Mar 19, 2020
Closed
Version 2.0 automation moved this from To do to Done Mar 19, 2020
jackcmeyer added a commit that referenced this issue Mar 19, 2020
@jackcmeyer
Merge pull request #1932 from alti21/master
8afecaa 
fix(#1915):  Mark Given Name as required for new/edit Patient
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alti21 alti21

Labels
🚀enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

fix(#1915): Mark Given Name as required for new/edit Patient alti21/hospitalrun-frontend
2 participants
@jackcmeyer @alti21