Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Provide better feedback in the New Patient/Edit Patient form #1918

Closed
jackcmeyer opened this issue Mar 18, 2020 · 5 comments 路 Fixed by #1938
Closed

Provide better feedback in the New Patient/Edit Patient form #1918

jackcmeyer opened this issue Mar 18, 2020 · 5 comments 路 Fixed by #1938
Assignees
@rubencgt
Labels
馃殌enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
Version 2.0
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

馃殌 Feature Proposal

Currently, the only error message that appears in the New Patient/Edit Patient form is a banner message that gives an error message.

When possible, we should provide feedback directly on the problematic field using: https://components.hospitalrun.io/?path=/story/textinput--invalid-text-field-with-error-message.

After completing this issue the following should be true:

  • When a user does not enter a given name for the user, the given name should highlight in red, and have a feedback message of: Given Name is required.
  • The banner message should read Could not create new patient./Could not update patient.

Motivation

Easier feedback cycle for a user.
@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun Mar 18, 2020
@jackcmeyer jackcmeyer added 馃殌enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor help wanted indicates that an issue is open for contributions patients issue/pull request that interacts with patients module labels Mar 18, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Mar 18, 2020
@rubencgt
Copy link
Contributor

rubencgt commented Mar 19, 2020 •
edited

maybe the isRequired from: https://components.hospitalrun.io/?path=/story/label--label
could be used?

@jackcmeyer
Copy link
Member Author

maybe the isRequired from: components.hospitalrun.io/?path=/story/label--label
could be used?

@rubencgt we have an issue: #1915 just for that.

@rubencgt
Copy link
Contributor

then I'd be happy to work on this

@jackcmeyer
Copy link
Member Author

@rubencgt I've assigned this to you.

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Mar 21, 2020
rubencgt added a commit to rubencgt/hospitalrun-frontend that referenced this issue Mar 22, 2020
@rubencgt
feat(patient): provide better feedback when creating/editing user
d173666 
fix HospitalRun#1918
@rubencgt rubencgt mentioned this issue Mar 22, 2020
Merged
@jackcmeyer
Copy link
Member Author

Closed via #1938

Version 2.0 automation moved this from To do to Done Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rubencgt rubencgt

Labels
馃殌enhancement an issue/pull request that adds a feature to the application good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

feat(patient): provide better feedback on patient form rubencgt/hospitalrun-frontend
2 participants
@rubencgt @jackcmeyer