Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(shared): pouchdb auth popup #2314

Merged
merged 12 commits into from
Sep 10, 2020
Merged

fix(shared): pouchdb auth popup #2314

merged 12 commits into from
Sep 10, 2020

Conversation

blestab
Copy link
Contributor

@blestab blestab commented Aug 17, 2020

Fixes #2256

Changes proposed in this pull request:

  • Add skip_setup flag to PouchDB instances creation
  • Update couchdb docker local.ini httpd section
  • Update nginx.conf

Newly added dependencies with Bundlephobia links:

NONE

@gitpod-io
Copy link

gitpod-io bot commented Aug 17, 2020

@blestab blestab added the 🐛bug issue/pull request that documents/fixes a bug label Aug 17, 2020
@blestab blestab added this to the v2.0 milestone Aug 17, 2020
@vercel
Copy link

vercel bot commented Aug 17, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/ouivrb790
✅ Preview: https://hospitalrun-frontend-git-fork-blestab-hrfeissue2256.hospitalrun.vercel.app

@morrme
Copy link
Contributor

morrme commented Aug 17, 2020

Hi @blestab , When using a fresh browser, I still see the popup:

popup

@jackcmeyer
Copy link
Member

@blestab and @morrme can confirm I also get the issue.

@jackcmeyer jackcmeyer marked this pull request as draft August 18, 2020 01:15
@blestab
Copy link
Contributor Author

blestab commented Aug 18, 2020

Thank you both, i'll try see what else i could be missing

@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Aug 30, 2020
@blestab blestab changed the title fix(shared): pouchdb auth - add skip_setup flag fix(shared): pouchdb auth popup fixes Sep 7, 2020
@blestab blestab changed the title fix(shared): pouchdb auth popup fixes fix(shared): pouchdb auth popup Sep 7, 2020
@jackcmeyer
Copy link
Member

@blestab still getting the issue with Chrome & Incognito

@morrme
Copy link
Contributor

morrme commented Sep 9, 2020

Still getting it too, new browser/private tab

@blestab
Copy link
Contributor Author

blestab commented Sep 9, 2020

Thanks @jackcmeyer @morrme, I think now i need to understand how the vercel/staging/live environments are built i.e. whether the nginx/couchdb config info is actually being used at all to build these environments.

@blestab
Copy link
Contributor Author

blestab commented Sep 9, 2020

@morrme @jackcmeyer

@tehkapa helped me update the couchDB config based on the ini changes in this PR. May you test for me if the popup is still coming up for you, I want to determine if we maybe need to force a rebuild of the vercel deployment.

@blestab blestab marked this pull request as ready for review September 9, 2020 14:50
@morrme
Copy link
Contributor

morrme commented Sep 9, 2020

NO popup for me! 🎊

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛bug issue/pull request that documents/fixes a bug in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix basic auth popup happening during login process
5 participants