Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Added a calendar that displays appointments (WIP) #823

Merged
merged 17 commits into from Jan 25, 2017
Merged

Added a calendar that displays appointments (WIP) #823

merged 17 commits into from Jan 25, 2017

Conversation

ghost
Copy link

@ghost ghost commented Nov 24, 2016

Fixes #760

Changes proposed in this pull request:

  • Bring in ember-fullcalendar;
  • Display appointments in a new route within the calendar;
  • Allow the user to get to an appointment's edit page via the calendar.

cc @HospitalRun/core-maintainers


This is still WIP. Stuff that still needs to be done:

  1. Automated tests.
  2. Extra query params to store the calendar's current settings (date and view type) when navigating to an appointment and back.
  3. This comment in the calendar route: // To cater for times like 0:00 - investigate.
  4. Write our own header to style the calendar controls so they look more like the rest of HR;
  5. The pinned 3.1.1 jQuery dependency was an initial workaround to get things running - have to check that out again;
  6. Anything else that comes up here.

Things that I don't like very much include the redundant first query for the model the calendar route performs. The idea there is a bit backwards, so I'm not sure how to avoid it. The model to load is indicated by the calendar control, but you need a loaded route to get the calendar control, so you always have two loads. When returning from an appointment, it will do the first redundant load, then reset the calendar to the passed in view config, then reload.

Throw all your critique my way 👍

@ghost
Copy link
Author

ghost commented Nov 24, 2016

As this progresses I'll try to get a live view of my branch going on some server somewhere. It's a fairly large addition and I feel screenshots/videos/gifs aren't that helpful for seeing how it works.

@jkleinsc jkleinsc added the in progress indicates that issue/pull request is currently being worked on label Nov 28, 2016
@jkleinsc
Copy link
Member

@BogdanAlexandru thanks for the update!

@jkleinsc
Copy link
Member

@BogdanAlexandru I need to move this feature along. If you aren't working on it, I'd like to take what you have and continue working on it myself.

@ghost
Copy link
Author

ghost commented Jan 19, 2017

I'm unable to work right now and won't be for the near future, taking over sounds like the way to go. The calendar-view branch has all of my latest changes, nothing on local needs pushing.

Sorry for the late notice on this.

@jkleinsc jkleinsc changed the base branch from master to calendar January 25, 2017 16:26
@jkleinsc
Copy link
Member

Merging existing PR into calendar branch so I can continue the work that @BogdanAlexandru started. Thanks @BogdanAlexandru for your efforts!

@jkleinsc jkleinsc merged commit 8ed67ee into HospitalRun:calendar Jan 25, 2017
@ghost ghost deleted the calendar-view branch January 30, 2017 21:27
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant