Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced flash :error key with :alert #80

Merged
merged 2 commits into from May 18, 2016
Merged

replaced flash :error key with :alert #80

merged 2 commits into from May 18, 2016

Conversation

Surzhko
Copy link
Contributor

@Surzhko Surzhko commented May 12, 2016 •
edited

Flash :alert key is more common usage than :error for setting errors in rails applications.
In devise gem also used :alert key (proof)

@Surzhko
Copy link
Contributor Author

Surzhko commented May 16, 2016

  • used devise helper for setting flashes
  • fixed spec with provisioning_url

@Houdini Houdini merged commit abc06c3 into Houdini:master May 18, 2016
@Houdini
Copy link
Owner

Houdini commented May 18, 2016

Thanks

@sbc100 sbc100 mentioned this pull request Jun 2, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Surzhko @Houdini