Various improvements for 1.2 (#1059)

HoudiniGraphql · Apr 19, 2023 · 46eb9c1 · 46eb9c1
1 parent 361e2b5
commit 46eb9c1
Show file tree

Hide file tree

Showing 30 changed files with 1,407 additions and 672 deletions.
diff --git a/.changeset/dirty-hornets-retire.md b/.changeset/dirty-hornets-retire.md
@@ -0,0 +1,5 @@
+---
+'houdini': patch
+---
+
+fix generated types when using a global loading directive
diff --git a/.changeset/mighty-pugs-matter.md b/.changeset/mighty-pugs-matter.md
@@ -0,0 +1,5 @@
+---
+'houdini': patch
+---
+
+Add cascade arg to loading
diff --git a/.changeset/serious-pumas-explode.md b/.changeset/serious-pumas-explode.md
@@ -0,0 +1,5 @@
+---
+'houdini': patch
+---
+
+Allow @loading to float if its also attached globally
diff --git a/packages/houdini-svelte/src/plugin/codegen/fragmentTypedefs/fragmentTypedefs.test.ts b/packages/houdini-svelte/src/plugin/codegen/fragmentTypedefs/fragmentTypedefs.test.ts
@@ -50,10 +50,10 @@ test('generates types for fragments', async function () {
 		import { TestFragment$input, TestFragment$data } from "../../../artifacts/TestFragment";
 		import { TestFragmentStore } from "../stores/TestFragment";
 		import type { FragmentStoreInstance } from "./types";
-		import { Fragment } from '$houdini/runtime/lib/types';
-		import { Readable } from 'svelte/store';
-		import { FragmentStore } from './stores';
-		import type { FragmentStorePaginated } from './stores/pagination/fragment';
+		import { Fragment } from "$houdini/runtime/lib/types";
+		import { Readable } from "svelte/store";
+		import { FragmentStore } from "./stores";
+		import type { FragmentStorePaginated } from "./stores/pagination/fragment";
 
 		export function fragment(
 		    initialValue: {
@@ -73,14 +73,20 @@ test('generates types for fragments', async function () {
 		    document: TestFragmentStore
 		): FragmentStoreInstance<TestFragment$data | null, TestFragment$input>;
 
-		export declare function fragment<_Fragment extends Fragment<any>>(ref: _Fragment, fragment: FragmentStore<_Fragment['shape']>): Readable<NonNullable<_Fragment['shape']>> & {
+		export declare function fragment<_Fragment extends Fragment<any>>(ref: _Fragment, fragment: FragmentStore<_Fragment["shape"]>): Readable<NonNullable<_Fragment["shape"]>> & {
 		    data: Readable<_Fragment>;
 		};
-		export declare function fragment<_Fragment extends Fragment<any>>(ref: _Fragment | null, fragment: FragmentStore<_Fragment['shape']>): Readable<NonNullable<_Fragment['shape']> | null> & {
+
+		export declare function fragment<_Fragment extends Fragment<any>>(ref: _Fragment | null, fragment: FragmentStore<_Fragment["shape"]>): Readable<NonNullable<_Fragment["shape"]> | null> & {
 		    data: Readable<_Fragment | null>;
 		};
-		export declare function paginatedFragment<_Fragment extends Fragment<any>>(initialValue: _Fragment | null, document: FragmentStore<_Fragment['shape']>): FragmentStorePaginated<_Fragment['shape'], {}>;
-		export declare function paginatedFragment<_Fragment extends Fragment<any>>(initialValue: _Fragment, document: FragmentStore<_Fragment['shape']>): FragmentStorePaginated<_Fragment['shape'], {}>;
+
+		export declare function paginatedFragment<_Fragment extends Fragment<any>>(
+		    initialValue: _Fragment | null,
+		    document: FragmentStore<_Fragment["shape"]>
+		): FragmentStorePaginated<_Fragment["shape"], {}>;
+
+		export declare function paginatedFragment<_Fragment extends Fragment<any>>(initialValue: _Fragment, document: FragmentStore<_Fragment["shape"]>): FragmentStorePaginated<_Fragment["shape"], {}>;
 	`)
 })
 
@@ -152,10 +158,10 @@ test('generates types for paginated fragments', async function () {
 		import { TestFragment$input, TestFragment$data } from "../../../artifacts/TestFragment";
 		import { TestFragmentStore } from "../stores/TestFragment";
 		import type { CursorFragmentStoreInstance } from "./types";
-		import { Fragment } from '$houdini/runtime/lib/types';
-		import { Readable } from 'svelte/store';
-		import { FragmentStore } from './stores';
-		import type { FragmentStorePaginated } from './stores/pagination/fragment';
+		import { Fragment } from "$houdini/runtime/lib/types";
+		import { Readable } from "svelte/store";
+		import { FragmentStore } from "./stores";
+		import type { FragmentStorePaginated } from "./stores/pagination/fragment";
 
 		export function fragment(
 		    initialValue: {
@@ -175,10 +181,11 @@ test('generates types for paginated fragments', async function () {
 		    document: TestFragmentStore
 		): CursorFragmentStoreInstance<TestFragment$data | null, TestFragment$input>;
 
-		export declare function fragment<_Fragment extends Fragment<any>>(ref: _Fragment, fragment: FragmentStore<_Fragment['shape']>): Readable<NonNullable<_Fragment['shape']>> & {
+		export declare function fragment<_Fragment extends Fragment<any>>(ref: _Fragment, fragment: FragmentStore<_Fragment["shape"]>): Readable<NonNullable<_Fragment["shape"]>> & {
 		    data: Readable<_Fragment>;
 		};
-		export declare function fragment<_Fragment extends Fragment<any>>(ref: _Fragment | null, fragment: FragmentStore<_Fragment['shape']>): Readable<NonNullable<_Fragment['shape']> | null> & {
+
+		export declare function fragment<_Fragment extends Fragment<any>>(ref: _Fragment | null, fragment: FragmentStore<_Fragment["shape"]>): Readable<NonNullable<_Fragment["shape"]> | null> & {
 		    data: Readable<_Fragment | null>;
 		};
 
@@ -200,7 +207,11 @@ test('generates types for paginated fragments', async function () {
 		    document: TestFragmentStore
 		): CursorFragmentStoreInstance<TestFragment$data | null, TestFragment$input>;
 
-		export declare function paginatedFragment<_Fragment extends Fragment<any>>(initialValue: _Fragment | null, document: FragmentStore<_Fragment['shape']>): FragmentStorePaginated<_Fragment['shape'], {}>;
-		export declare function paginatedFragment<_Fragment extends Fragment<any>>(initialValue: _Fragment, document: FragmentStore<_Fragment['shape']>): FragmentStorePaginated<_Fragment['shape'], {}>;
+		export declare function paginatedFragment<_Fragment extends Fragment<any>>(
+		    initialValue: _Fragment | null,
+		    document: FragmentStore<_Fragment["shape"]>
+		): FragmentStorePaginated<_Fragment["shape"], {}>;
+
+		export declare function paginatedFragment<_Fragment extends Fragment<any>>(initialValue: _Fragment, document: FragmentStore<_Fragment["shape"]>): FragmentStorePaginated<_Fragment["shape"], {}>;
 	`)
 })