Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow fragment arguments to get marshaled properly #1036

Conversation

SeppahBaws
Copy link
Collaborator

@SeppahBaws SeppahBaws commented Apr 4, 2023

This PR fixes a bug I was having, where list operations on a list inside of a fragment with arguments caused the fragment's store data to be set to null.

Apparently the fragment's arguments never got marshaled, so in the fragment store the variables was an empty object, and thus the lists in the fragment never got added to the cache's lists collection.

@AlecAivazis I was not entirely sure how to write a proper test case for this, some help with writing one would be appreciated :)

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot
Copy link

changeset-bot bot commented Apr 4, 2023

🦋 Changeset detected

Latest commit: 0a62e5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
houdini Patch
houdini-plugin-svelte-global-stores Patch
houdini-react Patch
houdini-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for houdinigraphql canceled.

Name Link
🔨 Latest commit 0a62e5c
🔍 Latest deploy log https://app.netlify.com/sites/houdinigraphql/deploys/642ca943a12fe6000868bb54

@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for visionary-croquembouche-0241c3 canceled.

Name Link
🔨 Latest commit 0a62e5c
🔍 Latest deploy log https://app.netlify.com/sites/visionary-croquembouche-0241c3/deploys/642ca943b2b73500081b5e26

@SeppahBaws SeppahBaws changed the title Bug/fragment arguments list operations Allow fragment arguments to get marshaled properly Apr 4, 2023
@AlecAivazis AlecAivazis enabled auto-merge (squash) April 4, 2023 22:49
@AlecAivazis AlecAivazis merged commit f0c1143 into HoudiniGraphql:main Apr 4, 2023
@github-actions github-actions bot mentioned this pull request Apr 4, 2023
@SeppahBaws SeppahBaws deleted the bug/fragment-arguments-list-operations branch April 5, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants