Allow fragment arguments to get marshaled properly #1036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug I was having, where list operations on a list inside of a fragment with arguments caused the fragment's store data to be set to null.
Apparently the fragment's arguments never got marshaled, so in the fragment store the variables was an empty object, and thus the lists in the fragment never got added to the cache's
lists
collection.@AlecAivazis I was not entirely sure how to write a proper test case for this, some help with writing one would be appreciated :)
To help everyone out, please make sure your PR does the following:
pnpm run tests
andcd integration && pnpm run tests
pnpm changeset