Add missing getMerchantId and setMerchantId in Gateway.php #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When you try to get default parameters for this gateway, it return an array of 3 things :
But, when you call :
and you debug the gateway variable, you see that the merchantId is empty whereas the certificate is correctly filled.
The reason is that the Gateway.php file have methods to set and get certificate, but not the merchantId. You can add the merchant Id by proving it as options when you call the completePurchase method for example, but it sound more logical to initialise it when you initialize the gateway, like the certificate. And for that, you need the get and set Method in the Gateway class.
Here is the PR that fix this
Best regards,