Options System using PlayerPrefs #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
reviewed
Feb 2, 2017
| public class AudioOptions | ||
| { | ||
| [Option("Master")] | ||
| public float master { get; set; } |
| [Option("SFX")] | ||
| public float sfx { get; set; } | ||
|
|
||
| public void Print() |
There was a problem hiding this comment.
Either use Log.Debug as it is functionally more complete than Debug.Log.
| Initialize(); | ||
| GetDataFromPrefs(); | ||
| var audio = Get<AudioOptions>(); | ||
| audio.Print(); |
There was a problem hiding this comment.
These value initialization should go in the individual Options classes themselves.
| public class OptionCategory : Attribute { | ||
| private string name; | ||
| public OptionCategory(string name) | ||
| { |
There was a problem hiding this comment.
Use K&R style bracing. We may want to set up a style-guide for Hourai Teahouse as a whole.
| select t; | ||
|
|
||
| StringBuilder allPropertiesStr = new StringBuilder(); | ||
| foreach (var t in q) |
There was a problem hiding this comment.
Do not use single letter variable names in foreach loops.
|
|
||
| T Get<T>() | ||
| { | ||
| object obj = optionObjs[typeof(T)]; |
|
|
||
| foreach (var p in t.GetProperties()) | ||
| { | ||
| StringBuilder keyStr = new StringBuilder(); |
There was a problem hiding this comment.
For short strings, use string interpolation via string.Format or just normal concatenation. StringBuilder is more suited for long complex strings.
james7132
changed the title
2. Removed type data from PlayerPref values
…ading data in registry
Prefs logs loading of PlayerPrefs and supports more types.
|
This is mostly ready, mainly missing two things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #48.
An attempt on reflection-based Option System.