Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: don't write to global variable CMAKE_CXX_STANDARD #754

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −4
Open

build: don't write to global variable CMAKE_CXX_STANDARD #754

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2ce5c1
build: don't write to global `CMAKE_CXX_STANDARD`
OlivierLDff Sep 26, 2022
039e414
build: bump minimum cmake version to 3.8 to make sure `cxx_std_11` ex…
OlivierLDff Dec 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

#]===================================================================]

cmake_minimum_required( VERSION 3.7 )
cmake_minimum_required( VERSION 3.8 )

project( date VERSION 3.0.1 )
set(ABI_VERSION 3) # used as SOVERSION, increment when ABI changes
Expand All @@ -24,9 +24,6 @@ include( GNUInstallDirs )

get_directory_property( has_parent PARENT_DIRECTORY )

# Override by setting on CMake command line.
set( CMAKE_CXX_STANDARD 17 CACHE STRING "The C++ standard whose features are requested." )

option( USE_SYSTEM_TZ_DB "Use the operating system's timezone database" OFF )
option( MANUAL_TZ_DB "User will set TZ DB manually by invoking set_install in their code" OFF )
option( USE_TZ_DB_IN_DOT "Save the timezone database in the current folder" OFF )
Expand Down Expand Up @@ -73,6 +70,7 @@ target_sources( date INTERFACE
$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/include/date/iso_week.h>
$<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/include/date/julian.h>
)
target_compile_features( date INTERFACE cxx_std_11 )
if (CMAKE_VERSION VERSION_GREATER_EQUAL 3.15)
# public headers will get installed:
set_target_properties( date PROPERTIES PUBLIC_HEADER include/date/date.h )
Expand Down