The caching algorithm should observe the max-age headers #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great thanks, can you please add your real name to the list of authors for both changed files. |
|
and on my machine contentWithLastModifiedTimeIsCachedAfterAFewPercentOfCreationAge fails - maybe because of date format issues (only a wild guess have not analyzed this) |
…remost, dropping back to `Last-Modified` with a heuristic as per RFC7234
ashleyfrieze
force-pushed
the
caching-max-age
branch
from
a5b5411
to
332a907
Compare
|
@rbri test failure was a minor test design issue - mixing hard coded time with calculated times. My mistake. I was rushing on a Friday evening. I've changed it to use per test constants relating to I've also modified the authors as requested. |
|
many thanks, feel free to provide more of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the foremost priority, dropping back to
Last-Modifiedwith a heuristic as per RFC7234This replaces the behaviour where the max-age headers were not considered at the time of caching, and where very recently
Last-Modifiedpages were NOT allowed in the cache either way.This change introduces some additional tests, with some test refactoring to avoid too many repeated constants.
It also centralises the logic for eviction and ingress into the cache.
It's a potential fix for #432