Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if no domains in list match agent, check for default domain #173

Merged
merged 1 commit into from
Apr 20, 2016

Conversation

ssalinas
Copy link
Member

I was using a check to see if the domains list was empty or not to determine if we check the default domain. We also need to check again for default domain if nothing in the provided list matches this agent's served domains.

In other words, fall back to default on that group for a service hosted on multiple groups where some do and some don't serve multiple domains.

@tpetr

@tpetr
Copy link
Contributor

tpetr commented Apr 20, 2016

LGTM

@ssalinas ssalinas merged commit 6a7f009 into master Apr 20, 2016
@ssalinas ssalinas deleted the no_domain_match branch April 20, 2016 15:40
@ssalinas ssalinas removed the staging label Apr 20, 2016
@ssalinas ssalinas modified the milestone: 0.3.0 Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants